Merge branch...

Merge branch '348469-update-tracking-for-the-continuous-onboarding-iteration-2-experiment' into 'master'

Update tracking for the Continuous Onboarding iteration 2 experiment

See merge request gitlab-org/gitlab!76979

app/experiments/change_continuous_onboarding_link_urls_experiment.rb

-# frozen_string_literal: true
-
-class ChangeContinuousOnboardingLinkUrlsExperiment < ApplicationExperiment # rubocop:disable Gitlab/NamespacedClass
-  attr_writer :namespace
-
-  def track(action, **event_args)
-    super(action, **event_args.merge(namespace: @namespace))
-  end
-end

app/helpers/learn_gitlab_helper.rb

@@ -27,8 +27,12 @@ module LearnGitlabHelper
 
     urls_to_use = nil
 
-    experiment(:change_continuous_onboarding_link_urls) do |e|
-      e.namespace = project.namespace
+    experiment(
+      :change_continuous_onboarding_link_urls,
+      namespace: project.namespace,
+      actor: current_user,
+      sticky_to: project.namespace
+    ) do |e|
       e.use { urls_to_use = action_urls }
       e.try { urls_to_use = new_action_urls(project) }
     end

spec/experiments/change_continuous_onboarding_link_urls_experiment_spec.rb

-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe ChangeContinuousOnboardingLinkUrlsExperiment, :snowplow do
-  before do
-    stub_experiments(change_continuous_onboarding_link_urls: 'control')
-  end
-
-  describe '#track' do
-    context 'when no namespace has been set' do
-      it 'tracks the action as normal' do
-        subject.track(:some_action)
-
-        expect_snowplow_event(
-          category: subject.name,
-          action: 'some_action',
-          namespace: nil,
-          context: [
-            {
-              schema: 'iglu:com.gitlab/gitlab_experiment/jsonschema/1-0-0',
-              data: an_instance_of(Hash)
-            }
-          ]
-        )
-      end
-    end
-
-    context 'when a namespace has been set' do
-      let_it_be(:namespace) { create(:namespace) }
-
-      before do
-        subject.namespace = namespace
-      end
-
-      it 'tracks the action and merges the namespace into the event args' do
-        subject.track(:some_action)
-
-        expect_snowplow_event(
-          category: subject.name,
-          action: 'some_action',
-          namespace: namespace,
-          context: [
-            {
-              schema: 'iglu:com.gitlab/gitlab_experiment/jsonschema/1-0-0',
-              data: an_instance_of(Hash)
-            }
-          ]
-        )
-      end
-    end
-  end
-end

spec/helpers/learn_gitlab_helper_spec.rb

@@ -176,6 +176,19 @@ RSpec.describe LearnGitlabHelper do
                                                    )
                                                  })
       end
+
+      it 'calls experiment with expected context & options' do
+        allow(helper).to receive(:current_user).and_return(user)
+
+        expect(helper).to receive(:experiment).with(
+          :change_continuous_onboarding_link_urls,
+          namespace: namespace,
+          actor: user,
+          sticky_to: namespace
+        )
+
+        learn_gitlab_data
+      end
     end
   end
 end