Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b51b1062
Commit
b51b1062
authored
Aug 16, 2017
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed issue boards focus mode not being visible to guest users
Closes #3182
parent
79ed8e83
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
36 additions
and
8 deletions
+36
-8
app/assets/javascripts/boards/boards_bundle.js
app/assets/javascripts/boards/boards_bundle.js
+14
-6
app/assets/stylesheets/pages/boards.scss
app/assets/stylesheets/pages/boards.scss
+1
-1
app/views/shared/issuable/_search_bar.html.haml
app/views/shared/issuable/_search_bar.html.haml
+1
-1
changelogs/unreleased-ee/guest-focus-mode.yml
changelogs/unreleased-ee/guest-focus-mode.yml
+5
-0
spec/features/boards/focus_mode_spec.rb
spec/features/boards/focus_mode_spec.rb
+15
-0
No files found.
app/assets/javascripts/boards/boards_bundle.js
View file @
b51b1062
...
...
@@ -140,11 +140,18 @@ $(() => {
gl
.
IssueBoardsModalAddBtn
=
new
Vue
({
mixins
:
[
gl
.
issueBoards
.
ModalMixins
],
el
:
document
.
getElementById
(
'
js-add-issues-btn
'
),
data
:
{
modal
:
ModalStore
.
store
,
store
:
Store
.
state
,
isFullscreen
:
false
,
focusModeAvailable
:
gl
.
utils
.
convertPermissionToBoolean
(
$boardApp
.
dataset
.
focusModeAvailable
),
data
()
{
return
{
modal
:
ModalStore
.
store
,
store
:
Store
.
state
,
isFullscreen
:
false
,
focusModeAvailable
:
gl
.
utils
.
convertPermissionToBoolean
(
$boardApp
.
dataset
.
focusModeAvailable
,
),
canAdminList
:
gl
.
utils
.
convertPermissionToBoolean
(
this
.
$options
.
el
.
dataset
.
canAdminList
,
),
};
},
watch
:
{
disabled
()
{
...
...
@@ -202,12 +209,13 @@ $(() => {
:class="{ 'disabled': disabled }"
:title="tooltipTitle"
:aria-disabled="disabled"
v-if="canAdminList"
@click="openModal">
Add issues
</button>
<a
href="#"
class="btn btn-default has-tooltip prepend-left-10"
class="btn btn-default has-tooltip prepend-left-10
js-focus-mode-btn
"
role="button"
aria-label="Toggle focus mode"
title="Toggle focus mode"
...
...
app/assets/stylesheets/pages/boards.scss
View file @
b51b1062
...
...
@@ -75,7 +75,7 @@
top
:
0
;
left
:
0
;
background
:
$white-light
;
z-index
:
5
00
;
z-index
:
90
00
;
.boards-list
{
height
:
calc
(
100vh
-
50px
);
...
...
app/views/shared/issuable/_search_bar.html.haml
View file @
b51b1062
...
...
@@ -126,6 +126,6 @@
-
if
can?
(
current_user
,
:admin_label
,
@project
)
=
render
partial:
"shared/issuable/label_page_create"
=
dropdown_loading
#js-add-issues-btn
.prepend-left-10
#js-add-issues-btn
.prepend-left-10
{
data:
{
can_admin_list:
can?
(
current_user
,
:admin_list
,
@project
).
to_s
}
}
-
elsif
type
!=
:boards_modal
=
render
'shared/sort_dropdown'
changelogs/unreleased-ee/guest-focus-mode.yml
0 → 100644
View file @
b51b1062
---
title
:
Fix issue boards focus button not being visible to guest users
merge_request
:
author
:
type
:
fixed
spec/features/boards/focus_mode_spec.rb
0 → 100644
View file @
b51b1062
require
'rails_helper'
describe
'Issue Boards focus mode'
,
:js
do
let
(
:project
)
{
create
(
:project
,
:public
)
}
before
do
visit
project_boards_path
(
project
)
wait_for_requests
end
it
"shows focus mode button to guest users"
do
expect
(
page
).
to
have_selector
(
'.board-extra-actions .js-focus-mode-btn'
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment