Merge branch 'sy-replace-shift-factory-defaults' into 'master'

Swap to more sensible shift factory defaults

See merge request gitlab-org/gitlab!52539

ee/spec/factories/incident_management/oncall_shifts.rb

@@ -4,7 +4,7 @@ FactoryBot.define do
   factory :incident_management_oncall_shift, class: 'IncidentManagement::OncallShift' do
     association :participant, :with_developer_access, factory: :incident_management_oncall_participant
     rotation { participant.rotation }
-    starts_at { 5.days.ago }
-    ends_at { 2.days.from_now }
+    starts_at { rotation.starts_at }
+    ends_at { starts_at + rotation.shift_duration }
   end
 end