Merge branch 'rspec-empty-line-after-letitbe-ee-spec-finders' into 'master'

Fix RSpec/EmptyLineAfterFinalLetItBe for ee/spec/finders

See merge request gitlab-org/gitlab!58394

.rubocop_manual_todo.yml

@@ -460,20 +460,6 @@ RSpec/EmptyLineAfterFinalLetItBe:
     - ee/spec/features/projects/licenses/maintainer_views_policies_spec.rb
     - ee/spec/features/registrations/group_invites_during_signup_flow_spec.rb
     - ee/spec/features/subscriptions_spec.rb
-    - ee/spec/finders/analytics/cycle_analytics/stage_finder_spec.rb
-    - ee/spec/finders/billed_users_finder_spec.rb
-    - ee/spec/finders/custom_project_templates_finder_spec.rb
-    - ee/spec/finders/deployments_finder_spec.rb
-    - ee/spec/finders/ee/projects_finder_spec.rb
-    - ee/spec/finders/epics_finder_spec.rb
-    - ee/spec/finders/geo_node_finder_spec.rb
-    - ee/spec/finders/incident_management/oncall_schedules_finder_spec.rb
-    - ee/spec/finders/issues_finder_spec.rb
-    - ee/spec/finders/iterations_finder_spec.rb
-    - ee/spec/finders/merge_trains_finder_spec.rb
-    - ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb
-    - ee/spec/finders/scim_finder_spec.rb
-    - ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb
     - ee/spec/graphql/ee/mutations/concerns/mutations/resolves_issuable_spec.rb
     - ee/spec/graphql/mutations/boards/update_epic_user_preferences_spec.rb
     - ee/spec/graphql/mutations/clusters/agent_tokens/create_spec.rb

ee/changelogs/unreleased/rspec-empty-lines-after-letitbe-ee-spec-finders.yml

+---
+title: Fix RSpec/EmptyLineAfterFinalLetItBe rubocop offenses in ee/spec/finders
+merge_request: 58394
+author: Abdul Wadood @abdulwd
+type: fixed

ee/spec/finders/analytics/cycle_analytics/stage_finder_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe Analytics::CycleAnalytics::StageFinder do
   let_it_be(:group) { create(:group) }
+
   let(:stage_id) { { id: Gitlab::Analytics::CycleAnalytics::DefaultStages.names.first } }
 
   subject { described_class.new(parent: group, stage_id: stage_id[:id]).execute }

ee/spec/finders/billed_users_finder_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe BilledUsersFinder do
   let_it_be(:group) { create(:group) }
+
   let(:search_term) { nil }
   let(:order_by) { nil }
 

ee/spec/finders/custom_project_templates_finder_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe CustomProjectTemplatesFinder do
   let_it_be(:user) { create(:user) }
+
   let(:base_params) { { current_user: user } }
   let(:params) { {} }
 

ee/spec/finders/deployments_finder_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe DeploymentsFinder do
   context 'at group scope' do
     let_it_be(:group) { create(:group) }
     let_it_be(:subgroup) { create(:group, parent: group) }
+
     let(:group_project_1) { create(:project, :public, :test_repo, group: group) }
     let(:group_project_2) { create(:project, :public, :test_repo, group: group) }
     let(:subgroup_project_1) { create(:project, :public, :test_repo, group: subgroup) }

ee/spec/finders/ee/projects_finder_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe ProjectsFinder do
   describe '#execute' do
     let_it_be(:user) { create(:user) }
+
     let(:finder) { described_class.new(current_user: user, params: params, project_ids_relation: project_ids_relation) }
 
     subject { finder.execute }

ee/spec/finders/epics_finder_spec.rb

@@ -521,6 +521,7 @@ RSpec.describe EpicsFinder do
           let_it_be(:public_group1) { create(:group, :public, parent: base_group) }
           let_it_be(:public_epic1) { create(:epic, group: public_group1) }
           let_it_be(:public_epic2) { create(:epic, :confidential, group: public_group1) }
+
           let(:execute_params) { {} }
 
           subject { described_class.new(search_user, group_id: base_group.id).execute(**execute_params) }

ee/spec/finders/geo_node_finder_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe GeoNodeFinder do
   let_it_be(:geo_node1) { create(:geo_node) }
   let_it_be(:geo_node2) { create(:geo_node) }
   let_it_be(:geo_node3) { create(:geo_node) }
+
   let(:params) { {} }
 
   subject(:geo_nodes) { described_class.new(user, params).execute }

ee/spec/finders/incident_management/oncall_schedules_finder_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe IncidentManagement::OncallSchedulesFinder do
   let_it_be(:oncall_schedule) { create(:incident_management_oncall_schedule, project: project) }
   let_it_be(:another_oncall_schedule) { create(:incident_management_oncall_schedule, project: project) }
   let_it_be(:oncall_schedule_from_another_project) { create(:incident_management_oncall_schedule) }
+
   let(:params) { {} }
 
   describe '#execute' do

ee/spec/finders/issues_finder_spec.rb

@@ -49,6 +49,7 @@ RSpec.describe IssuesFinder do
 
       context 'filtering by assignee IDs' do
         let_it_be(:user3) { create(:user) }
+
         let(:params) { { assignee_ids: [user2.id, user3.id] } }
 
         before do
@@ -64,6 +65,7 @@ RSpec.describe IssuesFinder do
 
       context 'filter by username' do
         let_it_be(:user3) { create(:user) }
+
         let(:issuables) { issues }
 
         before do

ee/spec/finders/iterations_finder_spec.rb

@@ -8,6 +8,7 @@ RSpec.describe IterationsFinder do
   let_it_be(:project_1) { create(:project, namespace: group) }
   let_it_be(:project_2) { create(:project, namespace: group) }
   let_it_be(:user) { create(:user) }
+
   let!(:started_group_iteration) { create(:started_iteration, :skip_future_date_validation, group: group, title: 'one test', start_date: now - 1.day, due_date: now) }
   let!(:upcoming_group_iteration) { create(:iteration, group: group, start_date: 1.day.from_now, due_date: 2.days.from_now) }
   let!(:iteration_from_project_1) { create(:started_iteration, :skip_project_validation, project: project_1, start_date: 3.days.from_now, due_date: 4.days.from_now) }

ee/spec/finders/merge_trains_finder_spec.rb

@@ -6,6 +6,7 @@ RSpec.describe MergeTrainsFinder do
   let_it_be(:project) { create(:project) }
   let_it_be(:developer) { create(:user) }
   let_it_be(:guest) { create(:user) }
+
   let(:finder) { described_class.new(project, user, params) }
   let(:user) { developer }
   let(:params) { {} }

ee/spec/finders/projects/integrations/jira/issues_finder_spec.rb

@@ -5,6 +5,7 @@ require 'spec_helper'
 RSpec.describe Projects::Integrations::Jira::IssuesFinder do
   let_it_be(:project, refind: true) { create(:project) }
   let_it_be(:jira_service, reload: true) { create(:jira_service, project: project) }
+
   let(:params) { {} }
   let(:service) { described_class.new(project, params) }
 

ee/spec/finders/scim_finder_spec.rb

@@ -4,6 +4,7 @@ require 'spec_helper'
 
 RSpec.describe ScimFinder do
   let_it_be(:group) { create(:group) }
+
   let(:unused_params) { double }
 
   subject(:finder) { described_class.new(group) }

ee/spec/finders/security/pipeline_vulnerabilities_finder_spec.rb

@@ -23,6 +23,7 @@ RSpec.describe Security::PipelineVulnerabilitiesFinder do
     let_it_be(:artifact_cs) { create(:ee_ci_job_artifact, :container_scanning, job: build_cs, project: project) }
     let_it_be(:artifact_dast) { create(:ee_ci_job_artifact, :dast, job: build_dast, project: project) }
     let_it_be(:artifact_ds) { create(:ee_ci_job_artifact, :dependency_scanning, job: build_ds, project: project) }
+
     let!(:artifact_sast) { create(:ee_ci_job_artifact, :sast, job: build_sast, project: project) }
 
     let(:cs_count) { read_fixture(artifact_cs)['vulnerabilities'].count }