Merge branch 'leipert-remove-global-jquery' into 'master'

Move jquery plugin initialization away from main.js

See merge request gitlab-org/gitlab!41682

app/assets/javascripts/commons/jquery.js

@@ -2,6 +2,3 @@ import 'jquery';
 
 // common jQuery plugins
 import 'jquery-ujs';
-import 'jquery.caret'; // must be imported before at.js
-import '@gitlab/at.js';
-import 'vendor/jquery.scrollTo';

app/assets/javascripts/diff_notes/components/jump_to_discussion.js

@@ -2,6 +2,7 @@
 /* global CommentsStore */
 
 import $ from 'jquery';
+import 'vendor/jquery.scrollTo';
 import Vue from 'vue';
 import { __ } from '~/locale';
 

app/assets/javascripts/gfm_auto_complete.js

 import $ from 'jquery';
-import '@gitlab/at.js';
+import '~/lib/utils/jquery_at_who';
 import { escape, template } from 'lodash';
 import SidebarMediator from '~/sidebar/sidebar_mediator';
 import glRegexp from './lib/utils/regexp';

app/assets/javascripts/groups/components/app.vue

@@ -2,6 +2,7 @@
 /* global Flash */
 
 import $ from 'jquery';
+import 'vendor/jquery.scrollTo';
 import { GlLoadingIcon } from '@gitlab/ui';
 import { s__, sprintf } from '~/locale';
 import DeprecatedModal from '~/vue_shared/components/deprecated_modal.vue';

app/assets/javascripts/lib/utils/jquery_at_who.js

+import 'jquery';
+import 'jquery.caret'; // required by at.js
+import '@gitlab/at.js';

app/assets/javascripts/line_highlighter.js

 /* eslint-disable func-names, no-underscore-dangle, no-param-reassign, consistent-return */
 
 import $ from 'jquery';
+import 'vendor/jquery.scrollTo';
 
 // LineHighlighter
 //

app/assets/javascripts/merge_request_tabs.js

 /* eslint-disable no-new, class-methods-use-this */
 
 import $ from 'jquery';
+import 'vendor/jquery.scrollTo';
 import { GlBreakpointInstance as bp } from '@gitlab/ui/dist/utils';
 import Cookies from 'js-cookie';
 import createEventHub from '~/helpers/event_hub_factory';

app/assets/javascripts/notes.js

@@ -11,11 +11,10 @@ old_notes_spec.js is the spec for the legacy, jQuery notes application. It has n
  */
 
 import $ from 'jquery';
+import '~/lib/utils/jquery_at_who';
 import { escape, uniqueId } from 'lodash';
 import Cookies from 'js-cookie';
 import Autosize from 'autosize';
-import 'jquery.caret'; // required by at.js
-import '@gitlab/at.js';
 import Vue from 'vue';
 import { GlDeprecatedSkeletonLoading as GlSkeletonLoading } from '@gitlab/ui';
 import AjaxCache from '~/lib/utils/ajax_cache';

ee/app/assets/javascripts/gfm_auto_complete.js

 import $ from 'jquery';
+import '~/lib/utils/jquery_at_who';
 import GfmAutoComplete from '~/gfm_auto_complete';
 
 /**

ee/app/assets/javascripts/protected_tags/protected_tag_edit.js

 import $ from 'jquery';
+import 'vendor/jquery.scrollTo';
 import { find } from 'lodash';
 import AccessDropdown from '~/projects/settings/access_dropdown';
 import axios from '~/lib/utils/axios_utils';

spec/frontend/gfm_auto_complete_spec.js

 /* eslint no-param-reassign: "off" */
 
 import $ from 'jquery';
+import '~/lib/utils/jquery_at_who';
 import GfmAutoComplete, { membersBeforeSave } from 'ee_else_ce/gfm_auto_complete';
 
-import 'jquery.caret';
-import '@gitlab/at.js';
-
 import { TEST_HOST } from 'helpers/test_constants';
 import { getJSONFixture } from 'helpers/fixtures';