Commit b76354f1 authored by Lin Jen-Shin's avatar Lin Jen-Shin

Resolve conflicts, according to:

3f54ae10
parent 8c448a2c
...@@ -150,21 +150,19 @@ always in-sync with the codebase. ...@@ -150,21 +150,19 @@ always in-sync with the codebase.
[GitLab QA]: https://gitlab.com/gitlab-org/gitlab-qa [GitLab QA]: https://gitlab.com/gitlab-org/gitlab-qa
[part of GitLab Rails]: https://gitlab.com/gitlab-org/gitlab-ce/tree/master/qa [part of GitLab Rails]: https://gitlab.com/gitlab-org/gitlab-ce/tree/master/qa
<<<<<<< HEAD
### EE-specific tests ### EE-specific tests
EE-specific tests follows the same organization, but under the `spec/ee` folder. EE-specific tests follows the same organization, but under the `spec/ee` folder.
=======
## Test for what should not be there ## Test for what should not be there
This is particularly important for permission calls and might be called a This is particularly important for permission calls and might be called a
negative assertion: make sure only the bare minimum is returned and nothing else. negative assertion: make sure only the bare minimum is returned and nothing else.
See an issue about [leaking tokens] as an example of a vulnerability that is See an issue about [leaking tokens] as an example of a vulnerability that is
captured by such a test. captured by such a test.
[leaking tokens]: https://gitlab.com/gitlab-org/gitlab-ce/issues/37948 [leaking tokens]: https://gitlab.com/gitlab-org/gitlab-ce/issues/37948
>>>>>>> upstream/master
## How to test at the correct level? ## How to test at the correct level?
......
...@@ -47,14 +47,10 @@ The Kubernetes service takes the following parameters: ...@@ -47,14 +47,10 @@ The Kubernetes service takes the following parameters:
[Kubernetes dashboard](https://kubernetes.io/docs/tasks/access-application-cluster/web-ui-dashboard/#config) [Kubernetes dashboard](https://kubernetes.io/docs/tasks/access-application-cluster/web-ui-dashboard/#config)
(under **Config > Secrets**). (under **Config > Secrets**).
<<<<<<< HEAD
[namespace]: https://kubernetes.io/docs/user-guide/namespaces/
=======
TIP: **Tip:** TIP: **Tip:**
If you have a single cluster that you want to use for all your projects, If you have a single cluster that you want to use for all your projects,
you can pre-fill the settings page with a default template. To configure the you can pre-fill the settings page with a default template. To configure the
template, see [Services Templates](services_templates.md). template, see [Services Templates](services_templates.md).
>>>>>>> upstream/master
## Deployment variables ## Deployment variables
......
...@@ -173,15 +173,11 @@ module Gitlab ...@@ -173,15 +173,11 @@ module Gitlab
# TODO: please clean this up # TODO: please clean this up
def check_push_access!(changes) def check_push_access!(changes)
if project.repository_read_only? if project.repository_read_only?
<<<<<<< HEAD raise UnauthorizedError, ERROR_MESSAGES[:readonly]
raise UnauthorizedError, 'The repository is temporarily read-only. Please try again later.'
end end
if Gitlab::Geo.secondary? if Gitlab::Geo.secondary?
raise UnauthorizedError, ERROR_MESSAGES[:cannot_push_to_secondary_geo] raise UnauthorizedError, ERROR_MESSAGES[:cannot_push_to_secondary_geo]
=======
raise UnauthorizedError, ERROR_MESSAGES[:readonly]
>>>>>>> upstream/master
end end
if deploy_key if deploy_key
......
...@@ -19,10 +19,7 @@ module Gitlab ...@@ -19,10 +19,7 @@ module Gitlab
# Whether user is allowed, or not, we should update # Whether user is allowed, or not, we should update
# permissions to keep things clean # permissions to keep things clean
if access.allowed? if access.allowed?
<<<<<<< HEAD
access.update_user access.update_user
=======
>>>>>>> upstream/master
Users::UpdateService.new(user, user: user, last_credential_check_at: Time.now).execute Users::UpdateService.new(user, user: user, last_credential_check_at: Time.now).execute
true true
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment