Merge branch 'leipert-remove-ie11-polyfills' into 'master'

Remove IE11 specific polyfills

See merge request gitlab-org/gitlab!36830

app/assets/javascripts/commons/polyfills.js

-// Browser polyfills
-
-/**
- * Polyfill: fetch
- * @what https://fetch.spec.whatwg.org/
- * @why Because Apollo GraphQL client relies on fetch
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=fetch
- */
-import 'unfetch/polyfill/index';
-
 /**
- * Polyfill: FormData APIs
- * @what delete(), get(), getAll(), has(), set(), entries(), keys(), values(),
- *    and support for for...of
- * @why Because Apollo GraphQL client relies on fetch
- * @browsers Internet Explorer 11, Edge < 18
- * @see https://caniuse.com/#feat=mdn-api_formdata and subfeatures
+ * Polyfill
+ * @what requestIdleCallback
+ * @why To align browser features
+ * @browsers Safari (all versions)
+ * @see https://caniuse.com/#feat=requestidlecallback
  */
-import 'formdata-polyfill';
+window.requestIdleCallback =
+  window.requestIdleCallback ||
+  function requestShim(cb) {
+    const start = Date.now();
+    return setTimeout(() => {
+      cb({
+        didTimeout: false,
+        timeRemaining: () => Math.max(0, 50 - (Date.now() - start)),
+      });
+    }, 1);
+  };
 
-import './polyfills/custom_event';
-import './polyfills/element';
-import './polyfills/event';
-import './polyfills/nodelist';
-import './polyfills/request_idle_callback';
-import './polyfills/svg';
+window.cancelIdleCallback =
+  window.cancelIdleCallback ||
+  function cancelShim(id) {
+    clearTimeout(id);
+  };

app/assets/javascripts/commons/polyfills/custom_event.js

-/**
- * Polyfill: CustomEvent constructor
- * @what new CustomEvent()
- * @why Certain features, e.g. notes utilize this
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=customevent
- */
-if (typeof window.CustomEvent !== 'function') {
-  window.CustomEvent = function CustomEvent(event, params) {
-    const evt = document.createEvent('CustomEvent');
-    const evtParams = {
-      bubbles: false,
-      cancelable: false,
-      detail: undefined,
-      ...params,
-    };
-    evt.initCustomEvent(event, evtParams.bubbles, evtParams.cancelable, evtParams.detail);
-    return evt;
-  };
-  window.CustomEvent.prototype = Event;
-}

app/assets/javascripts/commons/polyfills/element.js

-/**
- * Polyfill
- * @what Element.classList
- * @why In order to align browser features
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=classlist
- */
-import 'classlist-polyfill';
-
-/**
- * Polyfill
- * @what Element.closest
- * @why In order to align browser features
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=element-closest
- */
-Element.prototype.closest =
-  Element.prototype.closest ||
-  function closest(selector, selectedElement = this) {
-    if (!selectedElement) return null;
-    return selectedElement.matches(selector)
-      ? selectedElement
-      : Element.prototype.closest(selector, selectedElement.parentElement);
-  };
-
-/**
- * Polyfill
- * @what Element.matches
- * @why In order to align browser features
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=mdn-api_element_matches
- */
-Element.prototype.matches =
-  Element.prototype.matches ||
-  Element.prototype.matchesSelector ||
-  Element.prototype.mozMatchesSelector ||
-  Element.prototype.msMatchesSelector ||
-  Element.prototype.oMatchesSelector ||
-  Element.prototype.webkitMatchesSelector ||
-  function matches(selector) {
-    const elms = (this.document || this.ownerDocument).querySelectorAll(selector);
-    let i = elms.length - 1;
-    while (i >= 0 && elms.item(i) !== this) {
-      i -= 1;
-    }
-    return i > -1;
-  };
-
-/**
- * Polyfill
- * @what ChildNode.remove, Element.remove, CharacterData.remove, DocumentType.remove
- * @why In order to align browser features
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=childnode-remove
- *
- * From the polyfill on MDN, https://developer.mozilla.org/en-US/docs/Web/API/ChildNode/remove#Polyfill
- */
-(arr => {
-  arr.forEach(item => {
-    if (Object.prototype.hasOwnProperty.call(item, 'remove')) {
-      return;
-    }
-    Object.defineProperty(item, 'remove', {
-      configurable: true,
-      enumerable: true,
-      writable: true,
-      value: function remove() {
-        if (this.parentNode !== null) {
-          this.parentNode.removeChild(this);
-        }
-      },
-    });
-  });
-})([Element.prototype, CharacterData.prototype, DocumentType.prototype]);

app/assets/javascripts/commons/polyfills/event.js

-/**
- * Polyfill: Event constructor
- * @what new Event()
- * @why To align browser support
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=mdn-api_event_event
- *
- * Although `initEvent` is deprecated for modern browsers it is the one supported by IE
- */
-if (typeof window.Event !== 'function') {
-  window.Event = function Event(event, params) {
-    const evt = document.createEvent('Event');
-    const evtParams = {
-      bubbles: false,
-      cancelable: false,
-      ...params,
-    };
-    evt.initEvent(event, evtParams.bubbles, evtParams.cancelable);
-    return evt;
-  };
-  window.Event.prototype = Event;
-}

app/assets/javascripts/commons/polyfills/nodelist.js

-/**
- * Polyfill
- * @what NodeList.forEach
- * @why To align browser support
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=mdn-api_nodelist_foreach
- */
-if (window.NodeList && !NodeList.prototype.forEach) {
-  NodeList.prototype.forEach = function forEach(callback, thisArg = window) {
-    for (let i = 0; i < this.length; i += 1) {
-      callback.call(thisArg, this[i], i, this);
-    }
-  };
-}

app/assets/javascripts/commons/polyfills/request_idle_callback.js

-/**
- * Polyfill
- * @what requestIdleCallback
- * @why To align browser features
- * @browsers Safari (all versions), Internet Explorer 11
- * @see https://caniuse.com/#feat=requestidlecallback
- */
-window.requestIdleCallback =
-  window.requestIdleCallback ||
-  function requestShim(cb) {
-    const start = Date.now();
-    return setTimeout(() => {
-      cb({
-        didTimeout: false,
-        timeRemaining: () => Math.max(0, 50 - (Date.now() - start)),
-      });
-    }, 1);
-  };
-
-window.cancelIdleCallback =
-  window.cancelIdleCallback ||
-  function cancelShim(id) {
-    clearTimeout(id);
-  };

app/assets/javascripts/commons/polyfills/svg.js

-/**
- * polyfill support for external SVG file references via <use xlink:href>
- * @what polyfill support for external SVG file references via <use xlink:href>
- * @why This is used in our GitLab SVG icon library
- * @browsers Internet Explorer 11
- * @see https://caniuse.com/#feat=mdn-svg_elements_use_external_uri
- * @see https//css-tricks.com/svg-use-external-source/
- */
-import svg4everybody from 'svg4everybody';
-
-svg4everybody();

changelogs/unreleased/leipert-remove-ie11-polyfills.yml

+---
+title: Remove Internet Explorer 11 specific polyfills
+merge_request: 36830
+author:
+type: removed

config/dependency_decisions.yml

@@ -454,12 +454,6 @@
     :why: https://github.com/jaredhanson/utils-merge/blob/v1.0.0/LICENSE
     :versions: []
     :when: 2017-09-16 05:18:26.193764000 Z
-- - :approve
-  - svg4everybody
-  - :who: Tim Zallmann
-    :why: CC0 1.0 - https://github.com/jonathantneal/svg4everybody/blob/master/LICENSE.md
-    :versions: []
-    :when: 2017-09-13 17:31:16.425819400 Z
 - - :license
   - "@gitlab/svgs"
   - MIT

package.json

@@ -63,7 +63,6 @@
     "bootstrap": "4.4.1",
     "brace-expansion": "^1.1.8",
     "cache-loader": "^4.1.0",
-    "classlist-polyfill": "^1.2.0",
     "clipboard": "^1.7.1",
     "codemirror": "^5.48.4",
     "codesandbox-api": "0.0.23",
@@ -86,7 +85,6 @@
     "emoji-unicode-version": "^0.2.1",
     "exports-loader": "^0.7.0",
     "file-loader": "^5.1.0",
-    "formdata-polyfill": "^3.0.19",
     "fuzzaldrin-plus": "^0.6.0",
     "glob": "^7.1.6",
     "graphql": "^14.0.2",
@@ -130,7 +128,6 @@
     "stickyfilljs": "^2.1.0",
     "string-hash": "1.1.3",
     "style-loader": "^1.1.3",
-    "svg4everybody": "2.1.9",
     "swagger-ui-dist": "^3.26.2",
     "three": "^0.84.0",
     "three-orbit-controls": "^82.1.0",
@@ -140,7 +137,6 @@
     "tiptap-commands": "^1.4.0",
     "tiptap-extensions": "^1.8.0",
     "tributejs": "5.1.3",
-    "unfetch": "^4.1.0",
     "url-loader": "^3.0.0",
     "uuid": "8.1.0",
     "visibilityjs": "^1.2.4",

spec/frontend/polyfills/element_spec.js

-import '~/commons/polyfills/element';
-
-describe('Element polyfills', () => {
-  let testContext;
-
-  beforeEach(() => {
-    testContext = {};
-  });
-
-  beforeEach(() => {
-    testContext.element = document.createElement('ul');
-  });
-
-  describe('matches', () => {
-    it('returns true if element matches the selector', () => {
-      expect(testContext.element.matches('ul')).toBeTruthy();
-    });
-
-    it("returns false if element doesn't match the selector", () => {
-      expect(testContext.element.matches('.not-an-element')).toBeFalsy();
-    });
-  });
-
-  describe('closest', () => {
-    beforeEach(() => {
-      testContext.childElement = document.createElement('li');
-      testContext.element.appendChild(testContext.childElement);
-    });
-
-    it('returns the closest parent that matches the selector', () => {
-      expect(testContext.childElement.closest('ul').toString()).toBe(
-        testContext.element.toString(),
-      );
-    });
-
-    it('returns itself if it matches the selector', () => {
-      expect(testContext.childElement.closest('li').toString()).toBe(
-        testContext.childElement.toString(),
-      );
-    });
-
-    it('returns undefined if nothing matches the selector', () => {
-      expect(testContext.childElement.closest('.no-an-element')).toBeFalsy();
-    });
-  });
-});

vendor/licenses.csv

@@ -227,7 +227,6 @@ chunky_png,1.3.5,MIT
 cipher-base,1.0.4,MIT
 citrus,3.0.2,MIT
 class-utils,0.3.6,MIT
-classlist-polyfill,1.2.0,Unlicense
 cli-cursor,2.1.0,MIT
 cli-width,2.1.0,ISC
 clipboard,1.7.1,MIT
@@ -447,7 +446,6 @@ follow-redirects,1.2.6,MIT
 font-awesome-rails,4.7.0.1,"MIT,SIL Open Font License"
 for-in,1.0.2,MIT
 formatador,0.2.5,MIT
-formdata-polyfill,3.0.11,MIT
 forwarded,0.1.2,MIT
 fragment-cache,0.2.1,MIT
 fresh,0.5.2,MIT
@@ -1046,7 +1044,6 @@ strip-json-comments,2.0.1,MIT
 style-loader,0.23.0,MIT
 supports-color,2.0.0,MIT
 supports-color,5.5.0,MIT
-svg4everybody,2.1.9,CC0-1.0
 symbol-observable,1.2.0,MIT
 sys-filesystem,1.1.6,Artistic 2.0
 tapable,1.1.0,MIT

yarn.lock

@@ -2827,11 +2827,6 @@ class-utils@^0.3.5:
     isobject "^3.0.0"
     static-extend "^0.1.1"
 
-classlist-polyfill@^1.2.0:
-  version "1.2.0"
-  resolved "https://registry.yarnpkg.com/classlist-polyfill/-/classlist-polyfill-1.2.0.tgz#935bc2dfd9458a876b279617514638bcaa964a2e"
-  integrity sha1-k1vC39lFiodrJ5YXUUY4vKqWSi4=
-
 clean-css@^4.1.6, clean-css@^4.2.1:
   version "4.2.1"
   resolved "https://registry.yarnpkg.com/clean-css/-/clean-css-4.2.1.tgz#2d411ef76b8569b6d0c84068dabe85b0aa5e5c17"
@@ -5165,11 +5160,6 @@ format@^0.2.2:
   resolved "https://registry.yarnpkg.com/format/-/format-0.2.2.tgz#d6170107e9efdc4ed30c9dc39016df942b5cb58b"
   integrity sha1-1hcBB+nv3E7TDJ3DkBbflCtctYs=
 
-formdata-polyfill@^3.0.19:
-  version "3.0.19"
-  resolved "https://registry.yarnpkg.com/formdata-polyfill/-/formdata-polyfill-3.0.19.tgz#72f517db3a646a5dd8c31af0edf111fd8f1e4cee"
-  integrity sha512-nRSp8nniopIOCLZOUE2omwnUvmRH6VEdKm52rLTne8XBsW7hMMBUiOjuxUPoBsiK0CatKmxArh+Svt2s7R66JQ==
-
 forwarded@~0.1.2:
   version "0.1.2"
   resolved "https://registry.yarnpkg.com/forwarded/-/forwarded-0.1.2.tgz#98c23dab1175657b8c0573e8ceccd91b0ff18c84"
@@ -11206,11 +11196,6 @@ svg-tags@^1.0.0:
   resolved "https://registry.yarnpkg.com/svg-tags/-/svg-tags-1.0.0.tgz#58f71cee3bd519b59d4b2a843b6c7de64ac04764"
   integrity sha1-WPcc7jvVGbWdSyqEO2x95krAR2Q=
 
-svg4everybody@2.1.9:
-  version "2.1.9"
-  resolved "https://registry.yarnpkg.com/svg4everybody/-/svg4everybody-2.1.9.tgz#5bd9f6defc133859a044646d4743fabc28db7e2d"
-  integrity sha1-W9n23vwTOFmgRGRtR0P6vCjbfi0=
-
 swagger-ui-dist@^3.26.2:
   version "3.26.2"
   resolved "https://registry.yarnpkg.com/swagger-ui-dist/-/swagger-ui-dist-3.26.2.tgz#22c700906c8911b1c9956da6c3fca371dba6219f"
@@ -11736,11 +11721,6 @@ underscore@~1.8.3:
   resolved "https://registry.yarnpkg.com/underscore/-/underscore-1.8.3.tgz#4f3fb53b106e6097fcf9cb4109f2a5e9bdfa5022"
   integrity sha1-Tz+1OxBuYJf8+ctBCfKl6b36UCI=
 
-unfetch@^4.1.0:
-  version "4.1.0"
-  resolved "https://registry.yarnpkg.com/unfetch/-/unfetch-4.1.0.tgz#6ec2dd0de887e58a4dee83a050ded80ffc4137db"
-  integrity sha512-crP/n3eAPUJxZXM9T80/yv0YhkTEx2K1D3h7D1AJM6fzsWZrxdyRuLN0JH/dkZh1LNH8LxCnBzoPFCPbb2iGpg==
-
 unherit@^1.0.4:
   version "1.1.1"
   resolved "https://registry.yarnpkg.com/unherit/-/unherit-1.1.1.tgz#132748da3e88eab767e08fabfbb89c5e9d28628c"