Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b7916dea
Commit
b7916dea
authored
Oct 18, 2021
by
Tomislav Nikic
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adding a small fix
The button apears mutliple times. Now we only click on the first one.
parent
fa16b84a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
3 deletions
+3
-3
qa/qa/page/merge_request/show.rb
qa/qa/page/merge_request/show.rb
+1
-1
qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/batch_suggestion_spec.rb
...create/merge_request/suggestions/batch_suggestion_spec.rb
+2
-2
No files found.
qa/qa/page/merge_request/show.rb
View file @
b7916dea
...
@@ -354,7 +354,7 @@ module QA
...
@@ -354,7 +354,7 @@ module QA
end
end
def
apply_suggestion_with_message
(
message
)
def
apply_suggestion_with_message
(
message
)
click_element
(
:apply_suggestion_dropdown
)
all_elements
(
:apply_suggestion_dropdown
,
minimum:
1
).
first
.
click
fill_element
(
:commit_message_field
,
message
)
fill_element
(
:commit_message_field
,
message
)
click_element
(
:commit_with_custom_message_button
)
click_element
(
:commit_with_custom_message_button
)
end
end
...
...
qa/qa/specs/features/browser_ui/3_create/merge_request/suggestions/batch_suggestion_spec.rb
View file @
b7916dea
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
module
QA
module
QA
RSpec
.
describe
'Create'
do
RSpec
.
describe
'Create'
do
context
'Add batch suggestions to a Merge Request'
,
:transient
do
context
'Add batch suggestions to a Merge Request'
do
let
(
:project
)
do
let
(
:project
)
do
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
Resource
::
Project
.
fabricate_via_api!
do
|
project
|
project
.
name
=
'suggestions_project'
project
.
name
=
'suggestions_project'
...
@@ -46,7 +46,7 @@ module QA
...
@@ -46,7 +46,7 @@ module QA
merge_request
.
visit!
merge_request
.
visit!
end
end
it
'applies multiple suggestions'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/quality/test_cases/1838'
,
quarantine:
{
issue:
'https://gitlab.com/gitlab-org/gitlab/-/issues/342131'
,
type: :stale
}
do
it
'applies multiple suggestions'
,
testcase:
'https://gitlab.com/gitlab-org/quality/testcases/-/quality/test_cases/1838'
do
Page
::
MergeRequest
::
Show
.
perform
do
|
merge_request
|
Page
::
MergeRequest
::
Show
.
perform
do
|
merge_request
|
merge_request
.
click_diffs_tab
merge_request
.
click_diffs_tab
4
.
times
{
merge_request
.
add_suggestion_to_batch
}
4
.
times
{
merge_request
.
add_suggestion_to_batch
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment