Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
b9972049
Commit
b9972049
authored
Nov 17, 2020
by
Felipe Artur
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Default test cases feature flag to on
Default quality_test_cases feature flag to on
parent
9546e89c
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
10 additions
and
5 deletions
+10
-5
ee/app/controllers/projects/quality/test_cases_controller.rb
ee/app/controllers/projects/quality/test_cases_controller.rb
+2
-2
ee/app/services/quality_management/test_cases/create_service.rb
.../services/quality_management/test_cases/create_service.rb
+1
-1
ee/app/views/layouts/nav/_test_cases_link.html.haml
ee/app/views/layouts/nav/_test_cases_link.html.haml
+1
-1
ee/changelogs/unreleased/default_quality_test_cases_to_on.yml
...hangelogs/unreleased/default_quality_test_cases_to_on.yml
+5
-0
ee/config/feature_flags/development/quality_test_cases.yml
ee/config/feature_flags/development/quality_test_cases.yml
+1
-1
No files found.
ee/app/controllers/projects/quality/test_cases_controller.rb
View file @
b9972049
...
@@ -9,7 +9,7 @@ class Projects::Quality::TestCasesController < Projects::ApplicationController
...
@@ -9,7 +9,7 @@ class Projects::Quality::TestCasesController < Projects::ApplicationController
before_action
:authorize_create_issue!
,
only:
[
:new
]
before_action
:authorize_create_issue!
,
only:
[
:new
]
before_action
do
before_action
do
push_frontend_feature_flag
(
:quality_test_cases
,
project
)
push_frontend_feature_flag
(
:quality_test_cases
,
project
,
default_enabled:
true
)
end
end
feature_category
:quality_management
feature_category
:quality_management
...
@@ -45,7 +45,7 @@ class Projects::Quality::TestCasesController < Projects::ApplicationController
...
@@ -45,7 +45,7 @@ class Projects::Quality::TestCasesController < Projects::ApplicationController
private
private
def
verify_test_cases_flag!
def
verify_test_cases_flag!
render_404
unless
Feature
.
enabled?
(
:quality_test_cases
,
project
)
render_404
unless
Feature
.
enabled?
(
:quality_test_cases
,
project
,
default_enabled:
true
)
end
end
def
test_cases_finder
def
test_cases_finder
...
...
ee/app/services/quality_management/test_cases/create_service.rb
View file @
b9972049
...
@@ -43,7 +43,7 @@ module QualityManagement
...
@@ -43,7 +43,7 @@ module QualityManagement
end
end
def
can_create_test_cases?
def
can_create_test_cases?
project
.
feature_available?
(
:quality_management
)
&&
Feature
.
enabled?
(
:quality_test_cases
,
project
)
project
.
feature_available?
(
:quality_management
)
&&
Feature
.
enabled?
(
:quality_test_cases
,
project
,
default_enabled:
true
)
end
end
end
end
end
end
...
...
ee/app/views/layouts/nav/_test_cases_link.html.haml
View file @
b9972049
-
return
unless
Feature
.
enabled?
(
:quality_test_cases
,
project
)
-
return
unless
Feature
.
enabled?
(
:quality_test_cases
,
project
,
default_enabled:
true
)
-
return
unless
project
.
feature_available?
(
:quality_management
)
-
return
unless
project
.
feature_available?
(
:quality_management
)
-
return
unless
can?
(
current_user
,
:read_issue
,
project
)
-
return
unless
can?
(
current_user
,
:read_issue
,
project
)
...
...
ee/changelogs/unreleased/default_quality_test_cases_to_on.yml
0 → 100644
View file @
b9972049
---
title
:
Introduce quality test cases
merge_request
:
47948
author
:
type
:
added
ee/config/feature_flags/development/quality_test_cases.yml
View file @
b9972049
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241983
...
@@ -5,4 +5,4 @@ rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/241983
milestone
:
'
13.4'
milestone
:
'
13.4'
type
:
development
type
:
development
group
:
group::certify
group
:
group::certify
default_enabled
:
fals
e
default_enabled
:
tru
e
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment