Don't preload all memberships for a user

app/models/user.rb

@@ -1073,15 +1073,6 @@ class User < ActiveRecord::Base
     super
   end
 
-  # Get the membership for an object without loading the source of the membership
-  #
-  # This loads the entire `members` relation of the user, used on `current_user`
-  def membership_for_object(object)
-    members.sort('access_level_asc').detect do |member|
-      object.is_a?(member.source_type.constantize) && member.source_id == object.id
-    end
-  end
-
   protected
 
   # override, from Devise::Validatable

app/serializers/group_child_entity.rb

@@ -72,7 +72,7 @@ class GroupChildEntity < Grape::Entity
   def membership
     return unless request.current_user
 
-    @membership ||= request.current_user.membership_for_object(object)
+    @membership ||= request.current_user.members.find_by(source: object)
   end
 
   def project?