Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bb40f724
Commit
bb40f724
authored
Oct 13, 2020
by
alinamihaila
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make usage_data_api feature default enabled true
parent
7fffa6e9
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
10 additions
and
5 deletions
+10
-5
changelogs/unreleased/267114-enable-usage_data_api-by-default-feature.yml
...eased/267114-enable-usage_data_api-by-default-feature.yml
+5
-0
config/feature_flags/development/usage_data_api.yml
config/feature_flags/development/usage_data_api.yml
+2
-2
doc/development/product_analytics/usage_ping.md
doc/development/product_analytics/usage_ping.md
+1
-1
lib/api/usage_data.rb
lib/api/usage_data.rb
+1
-1
lib/gitlab/gon_helper.rb
lib/gitlab/gon_helper.rb
+1
-1
No files found.
changelogs/unreleased/267114-enable-usage_data_api-by-default-feature.yml
0 → 100644
View file @
bb40f724
---
title
:
Enable usage_data_api feature flag by default
merge_request
:
45004
author
:
type
:
other
config/feature_flags/development/usage_data_api.yml
View file @
bb40f724
---
name
:
usage_data_api
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41301
rollout_issue_url
:
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/267114
group
:
group::product analytics
type
:
development
default_enabled
:
fals
e
default_enabled
:
tru
e
doc/development/product_analytics/usage_ping.md
View file @
bb40f724
...
...
@@ -387,7 +387,7 @@ Implemented using Redis methods [PFADD](https://redis.io/commands/pfadd) and [PF
Increment unique users count using Redis HLL, for given event name.
Tracking events using the `
UsageData
` API requires the `
usage_data_api
` feature flag to be enabled, which is
dis
abled by default.
Tracking events using the `
UsageData
` API requires the `
usage_data_api
` feature flag to be enabled, which is
en
abled by default.
API requests are protected by checking for a valid CSRF token.
...
...
lib/api/usage_data.rb
View file @
bb40f724
...
...
@@ -6,7 +6,7 @@ module API
namespace
'usage_data'
do
before
do
not_found!
unless
Feature
.
enabled?
(
:usage_data_api
)
not_found!
unless
Feature
.
enabled?
(
:usage_data_api
,
default_enabled:
true
)
forbidden!
(
'Invalid CSRF token is provided'
)
unless
verified_request?
end
...
...
lib/gitlab/gon_helper.rb
View file @
bb40f724
...
...
@@ -47,7 +47,7 @@ module Gitlab
push_frontend_feature_flag
(
:monaco_ci
,
default_enabled:
true
)
push_frontend_feature_flag
(
:webperf_experiment
,
default_enabled:
false
)
push_frontend_feature_flag
(
:snippets_binary_blob
,
default_enabled:
false
)
push_frontend_feature_flag
(
:usage_data_api
,
default_enabled:
fals
e
)
push_frontend_feature_flag
(
:usage_data_api
,
default_enabled:
tru
e
)
# Startup CSS feature is a special one as it can be enabled by means of cookies and params
gon
.
push
({
features:
{
'startupCss'
=>
use_startup_css?
}
},
true
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment