Merge branch 'ag-fix-oauth-app-for-secondary' into 'master'

Fix oauth failure on primary

See merge request gitlab-org/gitlab!47178

ee/changelogs/unreleased/ag-fix-oauth-app-for-secondary.yml

+---
+title: 'Geo: Fix OAuth failure on primary'
+merge_request: 47178
+author:
+type: fixed

ee/lib/gitlab/geo.rb

@@ -88,7 +88,7 @@ module Gitlab
     end
 
     def self.oauth_authentication
-      return false unless Gitlab::Geo.secondary?
+      return unless Gitlab::Geo.secondary?
 
       self.cache_value(:oauth_application) do
         Gitlab::Geo.current_node.oauth_application || raise(OauthApplicationUndefinedError)

ee/spec/lib/gitlab/geo_spec.rb

@@ -143,12 +143,24 @@ RSpec.describe Gitlab::Geo, :geo, :request_store do
   end
 
   describe '.oauth_authentication' do
-    before do
-      stub_secondary_node
-      stub_current_geo_node(secondary_node)
+    context 'for Geo secondary' do
+      before do
+        stub_secondary_node
+        stub_current_geo_node(secondary_node)
+      end
+
+      it_behaves_like 'a Geo cached value', :oauth_authentication, :oauth_application
     end
 
-    it_behaves_like 'a Geo cached value', :oauth_authentication, :oauth_application
+    context 'for Geo primary' do
+      before do
+        stub_current_geo_node(primary_node)
+      end
+
+      it 'returns nil' do
+        expect(described_class.oauth_authentication).to be_nil
+      end
+    end
   end
 
   describe '.connected?' do