Commit bc09ea58 authored by Takuya Noguchi's avatar Takuya Noguchi

Enable DeclarationOrder in scss-lint

parent 4daa6da5
...@@ -43,10 +43,11 @@ linters: ...@@ -43,10 +43,11 @@ linters:
# Rule sets should be ordered as follows: # Rule sets should be ordered as follows:
# - @extend declarations # - @extend declarations
# - @include declarations without inner @content # - @include declarations without inner @content
# - properties, @include declarations with inner @content # - properties
# - @include declarations with inner @content
# - nested rule sets. # - nested rule sets.
DeclarationOrder: DeclarationOrder:
enabled: false enabled: true
# `scss-lint:disable` control comments should be preceded by a comment # `scss-lint:disable` control comments should be preceded by a comment
# explaining why these linters are being disabled for this file. # explaining why these linters are being disabled for this file.
......
...@@ -231,11 +231,11 @@ ...@@ -231,11 +231,11 @@
.award-control-icon-positive, .award-control-icon-positive,
.award-control-icon-super-positive { .award-control-icon-super-positive {
@include transition(opacity, transform);
position: absolute; position: absolute;
left: 10px; left: 10px;
bottom: 6px; bottom: 6px;
opacity: 0; opacity: 0;
@include transition(opacity, transform);
} }
.award-control-text { .award-control-text {
......
...@@ -35,8 +35,8 @@ ...@@ -35,8 +35,8 @@
.open { .open {
.dropdown-menu, .dropdown-menu,
.dropdown-menu-nav { .dropdown-menu-nav {
display: block;
@include set-visible; @include set-visible;
display: block;
@media (max-width: $screen-xs-max) { @media (max-width: $screen-xs-max) {
width: 100%; width: 100%;
...@@ -184,6 +184,7 @@ ...@@ -184,6 +184,7 @@
.dropdown-menu, .dropdown-menu,
.dropdown-menu-nav { .dropdown-menu-nav {
@include set-invisible;
display: block; display: block;
position: absolute; position: absolute;
width: 100%; width: 100%;
...@@ -200,7 +201,6 @@ ...@@ -200,7 +201,6 @@
border: 1px solid $dropdown-border-color; border: 1px solid $dropdown-border-color;
border-radius: $border-radius-base; border-radius: $border-radius-base;
box-shadow: 0 2px 4px $dropdown-shadow-color; box-shadow: 0 2px 4px $dropdown-shadow-color;
@include set-invisible;
@media (max-width: $screen-sm-min) { @media (max-width: $screen-sm-min) {
width: 100%; width: 100%;
......
...@@ -165,8 +165,8 @@ ...@@ -165,8 +165,8 @@
.cur { .cur {
.avatar { .avatar {
border: 1px solid $white-light;
@include disableAllAnimation; @include disableAllAnimation;
border: 1px solid $white-light;
} }
} }
......
...@@ -100,9 +100,9 @@ ...@@ -100,9 +100,9 @@
} }
.table-mobile-header { .table-mobile-header {
@include flex-max-width(40);
color: $gl-text-color-secondary; color: $gl-text-color-secondary;
text-align: left; text-align: left;
@include flex-max-width(40);
@media (min-width: $screen-md-min) { @media (min-width: $screen-md-min) {
display: none; display: none;
......
...@@ -250,8 +250,8 @@ ...@@ -250,8 +250,8 @@
} }
.committed_ago { .committed_ago {
float: right;
@extend .cgray; @extend .cgray;
float: right;
} }
} }
} }
......
...@@ -24,9 +24,9 @@ ...@@ -24,9 +24,9 @@
.col-headers { .col-headers {
ul { ul {
@include clearfix;
margin: 0; margin: 0;
padding: 0; padding: 0;
@include clearfix;
} }
li { li {
...@@ -189,8 +189,8 @@ ...@@ -189,8 +189,8 @@
} }
li { li {
list-style-type: none;
@include clearfix; @include clearfix;
list-style-type: none;
} }
.stage-nav-item { .stage-nav-item {
...@@ -281,11 +281,11 @@ ...@@ -281,11 +281,11 @@
} }
.stage-event-item { .stage-event-item {
@include clearfix;
list-style-type: none; list-style-type: none;
padding: 0 0 $gl-padding; padding: 0 0 $gl-padding;
margin: 0 $gl-padding $gl-padding; margin: 0 $gl-padding $gl-padding;
border-bottom: 1px solid $gray-darker; border-bottom: 1px solid $gray-darker;
@include clearfix;
&:last-child { &:last-child {
border-bottom: none; border-bottom: none;
...@@ -307,9 +307,9 @@ ...@@ -307,9 +307,9 @@
&.issue-title, &.issue-title,
&.commit-title, &.commit-title,
&.merge-merquest-title { &.merge-merquest-title {
@include text-overflow();
max-width: 100%; max-width: 100%;
display: block; display: block;
@include text-overflow();
a { a {
color: $gl-text-color; color: $gl-text-color;
......
...@@ -91,6 +91,7 @@ ...@@ -91,6 +91,7 @@
.old_line, .old_line,
.new_line { .new_line {
@include user-select(none);
margin: 0; margin: 0;
border: none; border: none;
padding: 0 5px; padding: 0 5px;
...@@ -99,7 +100,6 @@ ...@@ -99,7 +100,6 @@
min-width: 35px; min-width: 35px;
max-width: 50px; max-width: 50px;
width: 35px; width: 35px;
@include user-select(none);
a { a {
float: left; float: left;
...@@ -354,12 +354,12 @@ ...@@ -354,12 +354,12 @@
} }
&.active { &.active {
cursor: default;
color: $gl-text-color;
&:hover { &:hover {
text-decoration: none; text-decoration: none;
} }
cursor: default;
color: $gl-text-color;
} }
&.disabled { &.disabled {
......
...@@ -121,10 +121,11 @@ ul.notes { ...@@ -121,10 +121,11 @@ ul.notes {
overflow-y: hidden; overflow-y: hidden;
.note-text { .note-text {
word-wrap: break-word;
@include md-typography; @include md-typography;
// Reset ul style types since we're nested inside a ul already // Reset ul style types since we're nested inside a ul already
@include bulleted-list; @include bulleted-list;
word-wrap: break-word;
ul.task-list { ul.task-list {
ul:not(.task-list) { ul:not(.task-list) {
padding-left: 1.3em; padding-left: 1.3em;
......
...@@ -137,6 +137,7 @@ ...@@ -137,6 +137,7 @@
} }
.pipeline-variable-row-remove-button { .pipeline-variable-row-remove-button {
@include transition(color);
flex-shrink: 0; flex-shrink: 0;
display: flex; display: flex;
justify-content: center; justify-content: center;
...@@ -147,7 +148,6 @@ ...@@ -147,7 +148,6 @@
background: transparent; background: transparent;
border: 0; border: 0;
color: $gl-text-color-secondary; color: $gl-text-color-secondary;
@include transition(color);
&:hover, &:hover,
&:focus { &:focus {
......
...@@ -587,9 +587,9 @@ pre.light-well { ...@@ -587,9 +587,9 @@ pre.light-well {
} }
.project-row { .project-row {
@include basic-list-stats;
display: flex; display: flex;
align-items: center; align-items: center;
@include basic-list-stats;
} }
h3 { h3 {
......
...@@ -5,13 +5,13 @@ ...@@ -5,13 +5,13 @@
} }
.example { .example {
padding: 15px;
border: 1px dashed $ui-dev-kit-example-border;
margin-bottom: 15px;
&::before { &::before {
content: "Example"; content: "Example";
color: $ui-dev-kit-example-color; color: $ui-dev-kit-example-color;
} }
padding: 15px;
border: 1px dashed $ui-dev-kit-example-border;
margin-bottom: 15px;
} }
} }
---
title: Enable DeclarationOrder in scss-lint
merge_request: 12805
author: Takuya Noguchi
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment