Rename CI vars for disabling Browser Performance testing

doc/topics/autodevops/customize.md

@@ -431,7 +431,7 @@ The following table lists variables used to disable jobs.
 | `license_scanning`                     | `LICENSE_MANAGEMENT_DISABLED`   | [From GitLab 12.8](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/22773) | If the variable is present, the job isn't created. |
 | `load_performance`                     | `LOAD_PERFORMANCE_DISABLED`     | From GitLab 13.2      | If the variable is present, the job isn't created. |
 | `nodejs-scan-sast`                     | `SAST_DISABLED`                 |                       | If the variable is present, the job isn't created. |
-| `performance`                          | `PERFORMANCE_DISABLED`          | From GitLab 11.0      | Browser performance. If the variable is present, the job isn't created. |
+| `performance`                          | `BROWSER_PERFORMANCE_DISABLED`  | From GitLab 11.0      | Browser performance. If the variable is present, the job isn't created. |
 | `phpcs-security-audit-sast`            | `SAST_DISABLED`                 |                       | If the variable is present, the job isn't created. |
 | `pmd-apex-sast`                        | `SAST_DISABLED`                 |                       | If the variable is present, the job isn't created. |
 | `retire-js-dependency_scanning`        | `DEPENDENCY_SCANNING_DISABLED`  |                       | If the variable is present, the job isn't created. |

ee/spec/lib/gitlab/ci/templates/Jobs/browser_performance_testing_gitlab_ci_yaml_spec.rb

@@ -47,13 +47,13 @@ RSpec.describe 'Jobs/Browser-Performance-Testing.gitlab-ci.yml' do
 
     shared_examples_for 'browser_performance job on tag or branch' do
       it 'by default' do
-        expect(build_names).to include('performance')
+        expect(build_names).to include('browser_performance')
       end
 
-      it 'when PERFORMANCE_DISABLED' do
-        create(:ci_variable, project: project, key: 'PERFORMANCE_DISABLED', value: '1')
+      it 'when BROWSER_PERFORMANCE_DISABLED' do
+        create(:ci_variable, project: project, key: 'BROWSER_PERFORMANCE_DISABLED', value: '1')
 
-        expect(build_names).not_to include('performance')
+        expect(build_names).not_to include('browser_performance')
       end
     end
 

lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml

@@ -11,7 +11,7 @@
 # * test: TEST_DISABLED
 # * code_quality: CODE_QUALITY_DISABLED
 # * license_management: LICENSE_MANAGEMENT_DISABLED
-# * performance: PERFORMANCE_DISABLED
+# * browser_performance: PERFORMANCE_DISABLED
 # * load_performance: LOAD_PERFORMANCE_DISABLED
 # * sast: SAST_DISABLED
 # * secret_detection: SECRET_DETECTION_DISABLED

lib/gitlab/ci/templates/Jobs/Browser-Performance-Testing.gitlab-ci.yml

@@ -72,6 +72,6 @@ browser_performance:
   rules:
     - if: '$CI_KUBERNETES_ACTIVE == null || $CI_KUBERNETES_ACTIVE == ""'
       when: never
-    - if: '$PERFORMANCE_DISABLED'
+    - if: '$BROWSER_PERFORMANCE_DISABLED'
       when: never
     - if: '$CI_COMMIT_TAG || $CI_COMMIT_BRANCH'

lib/gitlab/ci/templates/Jobs/Browser-Performance-Testing.latest.gitlab-ci.yml

@@ -72,6 +72,6 @@ browser_performance:
   rules:
     - if: '$CI_KUBERNETES_ACTIVE == null || $CI_KUBERNETES_ACTIVE == ""'
       when: never
-    - if: '$PERFORMANCE_DISABLED'
+    - if: '$BROWSER_PERFORMANCE_DISABLED'
       when: never
     - if: '$CI_COMMIT_TAG || $CI_COMMIT_BRANCH'

qa/qa/specs/features/browser_ui/8_monitor/cluster_with_prometheus.rb

@@ -17,7 +17,7 @@ module QA
       %w[
           CODE_QUALITY_DISABLED TEST_DISABLED LICENSE_MANAGEMENT_DISABLED
           SAST_DISABLED DAST_DISABLED DEPENDENCY_SCANNING_DISABLED
-          CONTAINER_SCANNING_DISABLED PERFORMANCE_DISABLED SECRET_DETECTION_DISABLED
+          CONTAINER_SCANNING_DISABLED BROWSER_PERFORMANCE_DISABLED SECRET_DETECTION_DISABLED
         ].each do |key|
         Resource::CiVariable.fabricate_via_api! do |resource|
           resource.project = @project