Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
bf6dd8ee
Commit
bf6dd8ee
authored
Dec 18, 2019
by
Jean du Plessis
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Introduces a Review-response SLO.
parent
13e60a2b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
13 additions
and
9 deletions
+13
-9
doc/development/code_review.md
doc/development/code_review.md
+13
-9
No files found.
doc/development/code_review.md
View file @
bf6dd8ee
...
...
@@ -259,24 +259,28 @@ Developers who have capacity can regularly check the list of [merge requests to
Since
[
unblocking others is always a top priority
](
https://about.gitlab.com/handbook/values/#global-optimization
)
,
reviewers are expected to review assigned merge requests in a timely manner,
even when this may negatively impact their other tasks and priorities.
Doing so allows everyone involved in the merge request to iterate faster as the
context is fresh in memory, improves contributors' experiences significantly.
context is fresh in memory, and improves contributors' experience significantly.
#### Review-response SLO
A turnaround time of two working days is usually acceptable, since engineers
will typically have other things to work on while they're waiting for review,
but don't hesitate to ask the author if it's unclear what time frame would be
acceptable, how urgent the review is, or how significant the blockage.
To ensure swift feedback to ready-to-review code, we maintain a
`Review-response`
Service-level Objective (SLO). The SLO is defined as:
If you don't think you'll be able to review a merge request within a reasonable
> * review-response SLO = (time when first review response is provided) - (time MR is assigned to reviewer) < 2 business days
If you don't think you'll be able to review a merge request within the
`Review-response`
SLO
time frame, let the author know as soon as possible and try to help them find
another reviewer or maintainer who will be able to, so that they can be unblocked
and get on with their work quickly. Of course, if you are out of office and have
and get on with their work quickly.
Of course, if you are out of office and have
[
communicated
](
https://about.gitlab.com/handbook/paid-time-off/#communicating-your-time-off
)
this through your GitLab.com Status, authors are expected to realize this and
find a different reviewer themselves.
When a merge request author
feels like they have
been blocked for longer than
is reasonable
, they are free to remind the reviewer through Slack or assign
When a merge request author
has
been blocked for longer than
the
`Review-response`
SLO
, they are free to remind the reviewer through Slack or assign
another reviewer.
### Reviewing code
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment