Commit bf850c6e authored by Brett Walker's avatar Brett Walker

Address review comments

parent 3ff304bc
......@@ -207,14 +207,16 @@ These types of queries are not supported. In these instances, you can use offset
### Offset pagination
There are times when the complexity of sorting is more than our keyset pagination can handle.
There are times when the [complexity of sorting]((#limitations-of-query-complexity))
is more than our keyset pagination can handle.
For example in [`IssuesResolver`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/graphql/resolvers/issues_resolver.rb),
when sorting by `priority_asc`, we can't use keyset pagination, as the ordering is much
too complex (see [`issuable.rb`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/concerns/issuable.rb)).
In cases like this, we can fallback to using regular offset pagination by returning a
`Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection` instead of an `ActiveRecord::Relation`
[`Gitlab::Graphql::Pagination::OffsetActiveRecordRelationConnection`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/graphql/pagination/offset_active_record_relation_connection.rb)
instead of an `ActiveRecord::Relation`
For example:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment