Merge branch 'master' into '3145-document-how-geo-cursor-works'

# Conflicts:
#   doc/gitlab-geo/README.md

Gemfile.lock

@@ -1073,8 +1073,8 @@ DEPENDENCIES
   grape (~> 1.0)
   grape-entity (~> 0.6.0)
   grape-route-helpers (~> 2.1.0)
-  gssapi
   grape_logging (~> 1.6)
+  gssapi
   haml_lint (~> 0.26.0)
   hamlit (~> 2.6.1)
   hashie-forbidden_attributes

app/models/geo_node_status.rb

@@ -15,7 +15,9 @@ class GeoNodeStatus
   end
 
   def db_replication_lag
-    @db_replication_lag ||= Gitlab::Geo::HealthCheck.db_replication_lag
+    return @db_replication_lag if defined?(@db_replication_lag)
+
+    @db_replication_lag = Gitlab::Geo::HealthCheck.db_replication_lag if Gitlab::Geo.secondary?
   end
 
   def db_replication_lag=(value)
@@ -39,7 +41,9 @@ class GeoNodeStatus
   end
 
   def cursor_last_event_id
-    @cursor_last_event_id ||= cursor_last_processed&.event_id
+    return @cursor_last_event_id if defined?(@cursor_last_event_id)
+
+    @cursor_last_event_id = cursor_last_processed&.event_id if Gitlab::Geo.secondary?
   end
 
   def cursor_last_event_id=(value)

app/views/layouts/nav/sidebar/_project.html.haml

@@ -35,7 +35,7 @@
                 %span= _('Cycle Analytics')
 
       - if project_nav_tab? :files
-        = nav_link(controller: %w(tree blob blame edit_tree new_tree find_file commit commits compare projects/repositories tags branches releases graphs network)) do
+        = nav_link(controller: %w(tree blob blame edit_tree new_tree find_file commit commits compare projects/repositories tags branches releases graphs network path_locks)) do
           = sidebar_link project_tree_path(@project), title: _('Repository'),  css: 'shortcuts-tree' do
             .nav-icon-container
               = custom_icon('doc_text')
@@ -43,7 +43,7 @@
               Repository
 
           %ul.sidebar-sub-level-items
-            = nav_link(controller: %w(tree blob blame edit_tree new_tree find_file commit commits compare projects/repositories tags branches releases graphs network), html_options: { class: "fly-out-top-item" } ) do
+            = nav_link(controller: %w(tree blob blame edit_tree new_tree find_file commit commits compare projects/repositories tags branches releases graphs network path_locks), html_options: { class: "fly-out-top-item" } ) do
               = link_to project_tree_path(@project) do
                 %strong.fly-out-top-item-name
                   #{ _('Repository') }
@@ -124,9 +124,9 @@
                   List
 
             = nav_link(controller: :boards) do
-              = link_to project_boards_path(@project), title: 'Board' do
+              = link_to project_boards_path(@project), title: boards_link_text do
                 %span
-                  Board
+                  = boards_link_text
                 .feature-highlight.js-feature-highlight{ disabled: true, data: { trigger: 'manual', container: 'body', toggle: 'popover', placement: 'right', highlight: 'issue-boards' } }
               .feature-highlight-popover-content
                 = render 'feature_highlight/issue_boards.svg'
@@ -245,7 +245,7 @@
                   #{ _('Snippets') }
 
       - if project_nav_tab? :settings
-        = nav_link(path: %w[projects#edit project_members#index integrations#show services#edit repository#show ci_cd#show pages#show]) do
+        = nav_link(path: %w[projects#edit project_members#index integrations#show services#edit repository#show ci_cd#show pages#show audit_events#index]) do
           = sidebar_link edit_project_path(@project), title: _('Settings'), css: 'shortcuts-tree' do
             .nav-icon-container
               = custom_icon('settings')
@@ -255,7 +255,7 @@
           %ul.sidebar-sub-level-items
             - can_edit = can?(current_user, :admin_project, @project)
             - if can_edit
-              = nav_link(path: %w[projects#edit project_members#index integrations#show services#edit repository#show ci_cd#show pages#show], html_options: { class: "fly-out-top-item" } ) do
+              = nav_link(path: %w[projects#edit project_members#index integrations#show services#edit repository#show ci_cd#show pages#show audit_events#index], html_options: { class: "fly-out-top-item" } ) do
                 = link_to edit_project_path(@project) do
                   %strong.fly-out-top-item-name
                     #{ _('Settings') }

app/views/shared/boards/_show.html.haml

@@ -5,8 +5,6 @@
 - breadcrumb_title "Issue Boards"
 - page_title "Boards"
 
-- add_to_breadcrumbs("Issues", @issues_path)
-
 - content_for :page_specific_javascripts do
   = webpack_bundle_tag 'common_vue'
   = webpack_bundle_tag 'filtered_search'

changelogs/unreleased-ee/sh-fix-api-exception-handling.yml

+---
+title: 'Ensure #route_setting is available before calling it'
+merge_request: 2908
+author:
+type: fixed

changelogs/unreleased-ee/tc-geo-document-rake-tasks.yml

+---
+title: Add Geo rake task descriptions
+merge_request: 2925
+author:
+type: other

doc/administration/high_availability/redis.md

@@ -56,9 +56,9 @@ components below.
 ### High Availability with Sentinel
 
 >**Notes:**
-- Starting with GitLab `8.11`, you can configure a list of Redis Sentinel
+- Starting with GitLab 8.11, you can configure a list of Redis Sentinel
   servers that will monitor a group of Redis servers to provide failover support.
-- Starting with GitLab `8.14`, the Omnibus GitLab Enterprise Edition package
+- Starting with GitLab 8.14, the Omnibus GitLab Enterprise Edition package
   comes with Redis Sentinel daemon built-in.
 
 High Availability with Redis requires a few things:

doc/administration/job_artifacts.md

@@ -116,16 +116,13 @@ _The artifacts are stored by default in
     }
     ```
 
-    NOTE: If you are using AWS IAM profiles, you will need to specify a blank
-    AWS access key and ID until [this fog-aws
-    issue](https://github.com/fog/fog-aws/issues/162) is resolved. For example:
+    NOTE: For GitLab 9.4+, if you are using AWS IAM profiles, be sure to omit the
+    AWS access key and secret acces key/value pairs. For example:
 
     ```ruby
     gitlab_rails['artifacts_object_store_connection'] = {
       'provider' => 'AWS',
       'region' => 'eu-central-1',
-      'aws_access_key_id' => '',
-      'aws_secret_access_key' => '',
       'use_iam_profile' => true
     }
     ```

doc/api/todos.md

@@ -284,7 +284,7 @@ POST /todos/mark_as_done
 ```
 
 ```bash
-curl --request POST --header "PRIVATE-TOKEN: 9koXpg98eAheJpvBs5tK" https://gitlab.example.com/api/v4/todos/donmark_as_donee
+curl --request POST --header "PRIVATE-TOKEN: 9koXpg98eAheJpvBs5tK" https://gitlab.example.com/api/v4/todos/mark_as_done
 ```
 
 

doc/gitlab-geo/README.md

 # GitLab Geo
 
-NOTE: GitLab Geo is in ALPHA development. It is considered experimental and
+>**Note:**
+GitLab Geo is in **Beta** development. It is considered experimental and
 not production-ready. It will undergo significant changes over the next year,
 and there is significant chance of data loss. For the latest updates, check the
 [meta issue](https://gitlab.com/gitlab-org/gitlab-ee/issues/846).

doc/gitlab-geo/after_setup.md

@@ -3,12 +3,15 @@
 After you set up the [database replication and configure the GitLab Geo nodes][req],
 there are a few things to consider:
 
-1. When you create a new project in the primary node, the Git repository will
-   appear in the secondary only _after_ the first `git push`.
-1. You need an extra step to be able to fetch code from the `secondary` and push
-   to `primary`:
+1. Users need an extra step to be able to fetch code from the secondary and push
+   to primary:
+
+     1. Clone the repository as normal do from the secondary node:
+
+         ```bash
+         git clone git@secondary.gitlab.example.com:user/repo.git
+         ```
 
-     1. Clone your repository as you would normally do from the `secondary` node
      1. Change the remote push URL following this example:
 
          ```bash

doc/gitlab-geo/configuration.md

@@ -33,8 +33,9 @@ can be summed up to:
 
 1. Configure the primary node
 1. Replicate some required configurations between the primary and the secondaries
-1. Start GitLab in the secondary node's machine
+1. Configure a second, tracking database on each secondary
 1. Configure every secondary node in the primary's Admin screen
+1. Start GitLab on the secondary node's machine
 
 ### Prerequisites
 
@@ -49,6 +50,9 @@ first two steps of the [Setup instructions](README.md#setup-instructions):
 1. Your nodes must have an NTP service running to synchronize the clocks.
    You can use different timezones, but the hour relative to UTC can't be more
    than 60 seconds off from each node.
+1. You have set up another PostgreSQL database that can store writes for the secondary.
+   Note that this MUST be on another instance, since the primary replicated database
+   is read-only.
 
 Some of the following steps require to configure the primary and secondary
 nodes almost at the same time. For your convenience make sure you have SSH
@@ -106,7 +110,7 @@ sensitive data in the database. Any secondary node must have the
     sudo -i
     ```
 
-1. Added in GitLab 9.1: Execute the command below to display current encryption key and copy it:
+1. Execute the command below to display the current encryption key and copy it:
 
      ```
      gitlab-rake geo:db:show_encryption_key
@@ -134,16 +138,21 @@ sensitive data in the database. Any secondary node must have the
 
 ### Step 4. Regenerating the authorized keys in the secondary node
 
+> **IMPORTANT:** Since GitLab 10.0 `~/.ssh/authorized_keys` no longer
+> can be used, and this step is deprecated. Instead, follow the
+> instructions on [configuring SSH authorization via database lookups](../administration/operations/speed_up_ssh.html)
+> (for both primary AND secondary nodes).
+
 Regenerate the keys for `~/.ssh/authorized_keys`
 (HTTPS clone will still work without this extra step).
 
-On the **secondary** node where the database is [already replicated](./database.md),
-run:
+1. On the **secondary** node where the database is [already replicated](./database.md),
+   run:
 
-```
-# For Omnibus installations
-gitlab-rake gitlab:shell:setup
-```
+     ```
+     # For Omnibus installations
+     gitlab-rake gitlab:shell:setup
+     ```
 
 This will enable `git` operations to authorize against your existing users.
 New users and SSH keys updated after this step, will be replicated automatically.
@@ -187,10 +196,10 @@ The two most obvious issues that replication can have here are:
 
 ### Step 6. Replicating the repositories data
 
-Lastly, getting a new secondary Geo node up and running, will also require the
+Getting a new secondary Geo node up and running, will also require the
 repositories data to be synced.
 
-With GitLab **9.0** the syncing process starts automatically from the
+With GitLab 9.0 the syncing process starts automatically from the
 secondary node after the **Add Node** button is pressed.
 
 Currently, this is what is synced:
@@ -212,7 +221,7 @@ repository shards you must duplicate the same configuration on the secondary.
 
 Disabling a secondary node stops the syncing process.
 
-With GitLab **8.14** this process is started manually from the primary node.
+With GitLab 8.14 this process is started manually from the primary node.
 You can start the syncing process by clicking the "Backfill all repositories"
 button on `Admin > Geo Nodes` screen.
 
@@ -259,7 +268,7 @@ Point your users to the [after setup steps](after_setup.md).
 
 ## Selective replication
 
-With GitLab **9.5**, GitLab Geo now supports the first iteration of selective
+With GitLab 9.5, GitLab Geo now supports the first iteration of selective
 replication, which allows admins to choose which namespaces should be
 replicated by secondary nodes.
 

doc/gitlab-geo/configuration_source.md

@@ -22,9 +22,9 @@ in your testing/production environment.
 ## Setting up GitLab
 
 >**Notes:**
-- Don't setup any custom authentication in the secondary nodes, this will be
+- **Do not** setup any custom authentication in the secondary nodes, this will be
   handled by the primary node.
-- Do not add anything in the secondaries Geo nodes admin area
+- **Do not** add anything in the secondaries Geo nodes admin area
   (**Admin Area ➔ Geo Nodes**). This is handled solely by the primary node.
 
 After having installed GitLab Enterprise Edition in the instance that will serve
@@ -33,9 +33,9 @@ next steps can be summed up to:
 
 1. Configure the primary node
 1. Replicate some required configurations between the primary and the secondaries
-1. Configure a second, tracking database for each secondary
-1. Start GitLab in the secondary node's machine
+1. Configure a second, tracking database on each secondary
 1. Configure every secondary node in the primary's Admin screen
+1. Start GitLab on the secondary node's machine
 
 ### Prerequisites
 
@@ -47,6 +47,9 @@ first two steps of the [Setup instructions](README.md#setup-instructions):
 1. You have set up the database replication.
 1. Your secondary node is allowed to communicate via HTTP/HTTPS and SSH with
    your primary node (make sure your firewall is not blocking that).
+1. Your nodes must have an NTP service running to synchronize the clocks.
+   You can use different timezones, but the hour relative to UTC can't be more
+   than 60 seconds off from each node.
 1. You have set up another PostgreSQL database that can store writes for the secondary.
    Note that this MUST be on another instance, since the primary replicated database
    is read-only.
@@ -117,56 +120,37 @@ sensitive data in the database. Any secondary node must have the
     sudo -i
     ```
 
-1. (This step is required only if you want to enable the new Disaster Recovery
-   feature in Alpha shipped in GitLab 9.0) Create `database_geo.yml` with the
-   information of your secondary PostgreSQL database.
-   Note that this must be a totally different instance from the primary, since this
-   is where the secondary will track its internal state:
-
-    ```
-    sudo cp /home/git/gitlab/config/database_geo.yml.postgresql /home/git/gitlab/config/database_geo.yml
-    ```
+1. Open the secrets file and paste the value of `db_key_base` you copied in the
+   previous step:
 
-1. (This step is required only if you want to enable the new Disaster Recovery
-   feature in Alpha shipped in GitLab 9.0) Edit the content of `database_geo.yml`
-   in `production:` to be like the following:
-
-     ```yaml
-     #
-     # PRODUCTION
-     #
-     production:
-       adapter: postgresql
-       encoding: unicode
-       database: gitlabhq_geo_production
-       pool: 10
-       username: gitlab_geo
-       # password:
-       host: /var/opt/gitlab/geo-postgresql
-       port: 5431
      ```
+     editor /etc/gitlab/gitlab-secrets.json
+     ```
+
+1. Save and close the file.
 
-1. (This step is required only if you want to enable the new Disaster Recovery
-   feature in Alpha shipped in GitLab 9.0) Create the database
-   `gitlabhq_geo_production` in that PostgreSQL instance.
+### Step 4. Regenerating the authorized keys in the secondary node
 
-1. (This step is required only if you want to enable the new Disaster Recovery
-   feature in Alpha shipped in GitLab 9.0) Set up the Geo tracking database:
+> **IMPORTANT:** Since GitLab 10.0 `~/.ssh/authorized_keys` no longer
+> can be used, and this step is deprecated. Instead, follow the
+> instructions on [configuring SSH authorization via database lookups](../administration/operations/speed_up_ssh.html)
+> (for both primary AND secondary nodes).
 
-    ```
-    bundle exec rake geo:db:migrate
-    ```
+Regenerate the keys for `~/.ssh/authorized_keys`
+(HTTPS clone will still work without this extra step).
 
-1. Open the secrets file and paste the value of `db_key_base` you copied in the
-   previous step:
+1. On the **secondary** node where the database is [already replicated](./database.md),
+   run:
 
      ```
-     editor /home/git/gitlab/config/secrets.yml
+     # Installations from source
+     sudo -u git -H bundle exec rake gitlab:shell:setup RAILS_ENV=production
      ```
 
-1. Save and close the file.
+This will enable `git` operations to authorize against your existing users.
+New users and SSH keys updated after this step, will be replicated automatically.
 
-### Step 4. Enabling the secondary GitLab node
+### Step 5. Enabling the secondary GitLab node
 
 1. SSH into the **secondary** node and login as root:
 
@@ -193,6 +177,7 @@ sensitive data in the database. Any secondary node must have the
    in your browser.
 1. Add the secondary node by providing its full URL and the public SSH key
    you created previously. **Do NOT** check the box 'This is a primary node'.
+1. Added in GitLab 9.5: Choose which namespaces should be replicated by the secondary node. Leave blank to replicate all. Read more in [selective replication](#selective-replication).
 1. Click the **Add node** button.
 
 ---
@@ -210,12 +195,12 @@ The two most obvious issues that replication can have here are:
        [Troubleshooting](configuration.md#troubleshooting) section)
      - Instance is firewalled (check your firewall rules)
 
-### Step 5. Replicating the repositories data
+### Step 6. Replicating the repositories data
 
 Getting a new secondary Geo node up and running, will also require the
 repositories data to be synced.
 
-With GitLab **9.0** the syncing process starts automatically from the
+With GitLab 9.0 the syncing process starts automatically from the
 secondary node after the **Add Node** button is pressed.
 
 Currently, this is what is synced:
@@ -230,11 +215,14 @@ You can monitor the status of the syncing process on a secondary node
 by visiting the primary node's **Admin Area ➔ Geo Nodes** (`/admin/geo_nodes`)
 in your browser.
 
+Please note that if `git_data_dirs` is customized on the primary for multiple
+repository shards you must duplicate the same configuration on the secondary.
+
 ![GitLab Geo dashboard](img/geo-node-dashboard.png)
 
 Disabling a secondary node stops the syncing process.
 
-With GitLab **8.14** this process is started manually from the primary node.
+With GitLab 8.14 this process is started manually from the primary node.
 You can start the syncing process by clicking the "Backfill all repositories"
 button on `Admin > Geo Nodes` screen.
 
@@ -267,22 +255,6 @@ While active repositories will be eventually replicated, if you don't rsync,
 the files, any archived/inactive repositories will not get in the secondary node
 as Geo doesn't run any routine task to look for missing repositories.
 
-### Step 6. Regenerating the authorized keys in the secondary node
-
-The final step is to regenerate the keys for `~/.ssh/authorized_keys`
-(HTTPS clone will still work without this extra step).
-
-On the **secondary** node where the database is [already replicated](./database.md),
-run:
-
-```
-# Installations from source
-sudo -u git -H bundle exec rake gitlab:shell:setup RAILS_ENV=production
-```
-
-This will enable `git` operations to authorize against your existing users.
-New users and SSH keys updated after this step, will be replicated automatically.
-
 ## Next steps
 
 Your nodes should now be ready to use. You can login to the secondary node
@@ -295,6 +267,10 @@ If your installation isn't working properly, check the
 
 Point your users to the [after setup steps](after_setup.md).
 
+## Selective replication
+
+Read [Selective replication](configuration.md#selective-replication).
+
 ## Adding another secondary Geo node
 
 To add another Geo node in an already Geo configured infrastructure, just follow

doc/gitlab-geo/database.md

@@ -8,7 +8,7 @@ from source, follow the
 1. [Install GitLab Enterprise Edition][install-ee] on the server that will serve
    as the secondary Geo node. Do not login or set up anything else in the
    secondary node for the moment.
-1. **Setup the database replication (`primary (read-write) <-> secondary (read-only)` topology).**
+1. **Setup the database replication topology:** `primary (read-write) <-> secondary (read-only)`
 1. [Configure GitLab](configuration.md) to set the primary and secondary nodes.
 1. [Follow the after setup steps](after_setup.md).
 
@@ -24,14 +24,14 @@ in your testing/production environment.
 ## PostgreSQL replication
 
 The GitLab primary node where the write operations happen will connect to
-`primary` database server, and the secondary ones which are read-only will
-connect to `secondary` database servers (which are read-only too).
+primary database server, and the secondary ones which are read-only will
+connect to secondary database servers (which are read-only too).
 
 >**Note:**
-In many databases documentation you will see `primary` being references as `master`
-and `secondary` as either `slave` or `standby` server (read-only).
+In many databases documentation you will see "primary" being referenced as "master"
+and "secondary" as either "slave" or "standby" server (read-only).
 
-New for GitLab 9.4: We recommend using [PostgreSQL replication
+Since GitLab 9.4: We recommend using [PostgreSQL replication
 slots](https://medium.com/@tk512/replication-slots-in-postgresql-b4b03d277c75)
 to ensure the primary retains all the data necessary for the secondaries to
 recover. See below for more details.
@@ -40,17 +40,17 @@ recover. See below for more details.
 
 The following guide assumes that:
 
-- You are using PostgreSQL 9.2 or later which includes the
+- You are using PostgreSQL 9.6 or later which includes the
   [`pg_basebackup` tool][pgback]. If you are using Omnibus it includes the required
   PostgreSQL version for Geo.
 - You have a primary server already set up (the GitLab server you are
   replicating from), running Omnibus' PostgreSQL (or equivalent version), and you
-  have a new secondary server set up on the same OS and PostgreSQL version. If
-  you are using Omnibus, make sure the GitLab version is the same on all nodes.
+  have a new secondary server set up on the same OS and PostgreSQL version. Also
+  make sure the GitLab version is the same on all nodes.
 - The IP of the primary server for our examples will be `1.2.3.4`, whereas the
   secondary's IP will be `5.6.7.8`. Note that the primary and secondary servers
-  MUST be able to communicate over these addresses. These IP addresses can either
-  be public or private.
+  **must** be able to communicate over these addresses (using HTTPS & SSH).
+  These IP addresses can either be public or private.
 
 ### Step 1. Configure the primary server
 
@@ -177,13 +177,71 @@ The following guide assumes that:
     \q
     ```
 
-1. Added in GitLab 9.1: Edit `/etc/gitlab/gitlab.rb` and add the following:
+1. Edit `/etc/gitlab/gitlab.rb` and add the following:
 
     ```ruby
     geo_secondary_role['enable'] = true
+    ```
+
+1. Optional since GitLab 9.1, and required for GitLab 10.0 or higher:
+   [Enable tracking database on the secondary server](#enable-tracking-database-on-the-secondary-server)
+
+1. Otherwise, continue to [initiate the replication process](#step-3-initiate-the-replication-process).
+
+#### Enable tracking database on the secondary server
+
+Geo secondary nodes use a tracking database to keep track of replication status and recover
+automatically from some replication issues.
+
+It is added in GitLab 9.1, and since GitLab 10.0 it is required.
+
+> **IMPORTANT:** For this feature to work correctly, all nodes must be
+with their clocks synchronized. It is not required for all nodes to be set to
+the same time zone, but when the respective times are converted to UTC time,
+the clocks must be synchronized to within 60 seconds of each other.
+
+1. Setup clock synchronization service in your Linux distro.
+   This can easily be done via any NTP-compatible daemon. For example,
+   here are [instructions for setting up NTP with Ubuntu](https://help.ubuntu.com/lts/serverguide/NTP.html).
+
+
+1. Edit `/etc/gitlab/gitlab.rb` and add the following:
+
+    ```ruby
     geo_postgresql['enable'] = true
     ```
 
+1. Create `database_geo.yml` with the information of your secondary PostgreSQL
+   database.  Note that GitLab will set up another database instance separate
+   from the primary, since this is where the secondary will track its internal
+   state:
+
+    ```
+    sudo cp /opt/gitlab/embedded/service/gitlab-rails/config/database_geo.yml.postgresql /opt/gitlab/embedded/service/gitlab-rails/config/database_geo.yml
+    ```
+
+1. Edit the content of `database_geo.yml` in `production:` like the example below:
+
+   ```yaml
+   #
+   # PRODUCTION
+   #
+   production:
+     adapter: postgresql
+     encoding: unicode
+     database: gitlabhq_geo_production
+     pool: 10
+     username: gitlab_geo
+     # password:
+     host: /var/opt/gitlab/geo-postgresql
+   ```
+
+1. Set up the Geo tracking database:
+
+    ```
+    sudo gitlab-rake geo:db:migrate
+    ```
+
 1. [Reconfigure GitLab][] for the changes to take effect.
 1. Continue to [initiate the replication process](#step-3-initiate-the-replication-process).
 

doc/gitlab-geo/database_source.md

@@ -8,7 +8,7 @@ using the Omnibus GitLab packages, follow the
 1. [Install GitLab Enterprise Edition][install-ee-source] on the server that
    will serve as the secondary Geo node. Do not login or set up anything else
    in the secondary node for the moment.
-1. **Setup the database replication (`primary (read-write) <-> secondary (read-only)` topology).**
+1. **Setup the database replication topology:** `primary (read-write) <-> secondary (read-only)`
 1. [Configure GitLab](configuration_source.md) to set the primary and secondary
    nodes.
 1. [Follow the after setup steps](after_setup.md).
@@ -25,12 +25,17 @@ in your testing/production environment.
 ## PostgreSQL replication
 
 The GitLab primary node where the write operations happen will connect to
-`primary` database server, and the secondary ones which are read-only will
-connect to `secondary` database servers (which are read-only too).
+primary database server, and the secondary ones which are read-only will
+connect to secondary database servers (which are read-only too).
 
 >**Note:**
-In many databases documentation you will see `primary` being references as `master`
-and `secondary` as either `slave` or `standby` server (read-only).
+In many databases documentation you will see "primary" being referenced as "master"
+and "secondary" as either "slave" or "standby" server (read-only).
+
+Since GitLab 9.4: We recommend using [PostgreSQL replication
+slots](https://medium.com/@tk512/replication-slots-in-postgresql-b4b03d277c75)
+to ensure the primary retains all the data necessary for the secondaries to
+recover. See below for more details.
 
 ### Prerequisites
 
@@ -41,13 +46,15 @@ The following guide assumes that:
   PostgreSQL version for Geo.
 - You have a primary server already set up (the GitLab server you are
   replicating from), and you have a new secondary server set up on the same OS
-  and PostgreSQL version.
+  and PostgreSQL version. Also make sure the GitLab version is the same on all nodes.
 - The IP of the primary server for our examples will be `1.2.3.4`, whereas the
-  secondary's IP will be `5.6.7.8`.
+  secondary's IP will be `5.6.7.8`. Note that the primary and secondary servers
+  **must** be able to communicate over these addresses. These IP addresses can either
+  be public or private.
 
 ### Step 1. Configure the primary server
 
-1. SSH into your database **primary** server and login as root:
+1. SSH into your GitLab **primary** server and login as root:
 
     ```
     sudo -i
@@ -125,10 +132,11 @@ The following guide assumes that:
 1. Now that the PostgreSQL server is set up to accept remote connections, run
    `netstat -plnt` to make sure that PostgreSQL is listening to the server's
    public IP.
+1. Continue to [set up the secondary server](#step-2-configure-the-secondary-server).
 
 ### Step 2. Configure the secondary server
 
-1. SSH into your database **secondary** server and login as root:
+1. SSH into your GitLab **secondary** server and login as root:
 
     ```
     sudo -i
@@ -151,7 +159,7 @@ The following guide assumes that:
     ```
 
 1. Edit `postgresql.conf` to configure the secondary for streaming replication
-   (for Debian/Ubuntu that would be `/etc/postgresql/9.x/main/postgresql.conf`):
+   (for Debian/Ubuntu that would be `/etc/postgresql/9.*/main/postgresql.conf`):
 
     ```bash
     wal_level = hot_standby
@@ -162,7 +170,61 @@ The following guide assumes that:
     ```
 
 1. Restart PostgreSQL for the changes to take effect.
-1. Continue to [initiate the replication process](#step-3-initiate-the-replication-process).
+
+1. Optional since GitLab 9.1, and required for GitLab 10.0 or higher:
+   [Enable tracking database on the secondary server](#enable-tracking-database-on-the-secondary-server)
+
+1. Otherwise, continue to [initiate the replication process](#step-3-initiate-the-replication-process).
+
+#### Enable tracking database on the secondary server
+
+Geo secondary nodes use a tracking database to keep track of replication status and recover
+automatically from some replication issues.
+
+It is added in GitLab 9.1, and since GitLab 10.0 it is required.
+
+> **IMPORTANT:** For this feature to work correctly, all nodes must be
+with their clocks synchronized. It is not required for all nodes to be set to
+the same time zone, but when the respective times are converted to UTC time,
+the clocks must be synchronized to within 60 seconds of each other.
+
+1. Setup clock synchronization service in your Linux distro.
+   This can easily be done via any NTP-compatible daemon. For example,
+   here are [instructions for setting up NTP with Ubuntu](https://help.ubuntu.com/lts/serverguide/NTP.html).
+
+1. Create `database_geo.yml` with the information of your secondary PostgreSQL
+   database.  Note that GitLab will set up another database instance separate
+   from the primary, since this is where the secondary will track its internal
+   state:
+
+    ```
+    sudo cp /home/git/gitlab/config/database_geo.yml.postgresql /home/git/gitlab/config/database_geo.yml
+    ```
+
+1. Edit the content of `database_geo.yml` in `production:` like the example below:
+
+     ```yaml
+     #
+     # PRODUCTION
+     #
+     production:
+       adapter: postgresql
+       encoding: unicode
+       database: gitlabhq_geo_production
+       pool: 10
+       username: gitlab_geo
+       # password:
+       host: /var/opt/gitlab/geo-postgresql
+     ```
+
+1. Create the database `gitlabhq_geo_production` in that PostgreSQL
+   instance.
+
+1. Set up the Geo tracking database:
+
+    ```
+    bundle exec rake geo:db:migrate
+    ```
 
 ### Step 3. Initiate the replication process
 

doc/gitlab-geo/disaster-recovery.md

 # GitLab Geo Disaster Recovery
 
 > **Note:**
-This is not officially supported yet, please don't use as your only
-Disaster Recovery strategy as you may lose data.
+GitLab Geo Disaster Recovery is in **Alpha** development. Please don't
+use as your only Disaster Recovery strategy as you may lose data.
 
 GitLab Geo replicates your database and your Git repositories. We will
 support and replicate more data in the future, that will enable you to

doc/gitlab-geo/faq.md

@@ -25,12 +25,12 @@ primary node.
 ## How long does it take to have a commit replicated to a secondary node?
 
 All replication operations are asynchronous and are queued to be dispatched in
-a batched request every 10 seconds. Besides that, it depends on a lot of other
+a batched request every 10 minutes. Besides that, it depends on a lot of other
 factors including the amount of traffic, how big your commit is, the
 connectivity between your nodes, your hardware, etc.
 
-## What happens if the SSH server runs at a different port?
+## What if the SSH server runs at a different port?
 
 We send the clone url from the primary server to any secondaries, so it
-doesn't matter. If primary is running on port `2200` clone url will reflect
+doesn't matter. If primary is running on port `2200`, clone url will reflect
 that.

doc/gitlab-geo/ssh.md

@@ -6,6 +6,9 @@ single source of truth, Geo needs to be configured to perform SSH fingerprint
 lookups via database lookup. This approach is also much faster than scanning a
 file.
 
+>**Note:**
+GitLab 10.0 and higher require database lookups for SSH keys.
+
 Note this feature is only available on operating systems that support OpenSSH
 6.9 and above. For CentOS 6 and 7, see the [instructions on building custom
 version of OpenSSH for your server]

doc/gitlab-geo/updating_the_geo_nodes.md

@@ -10,7 +10,9 @@ all you need to do is update GitLab itself:
 
 1. Log into each node (primary and secondaries)
 1. [Update GitLab][update]
-1. Test primary and secondary nodes, and check version in each.
+1. [Update tracking database on secondary node](#update-tracking-database-on-secondary-node) when
+   the tracking database is enabled.
+1. [Test](#check-status-after-updating) primary and secondary nodes, and check version in each.
 
 ## Special update notes for 9.0.x
 
@@ -149,68 +151,18 @@ everything is working correctly:
 1. Test the data replication by pushing code to the primary and see if it
    is received by the secondaries
 
-## Enable tracking database
+## Update tracking database on secondary node
 
-NOTE: This step is required only if you want to enable the new Disaster
-Recovery feature in Alpha shipped in GitLab 9.0.
+After updating a secondary node, you might need to run migrations on
+the tracking database. The tracking database was added in GitLab 9.1,
+and it is required since 10.0.
 
-Geo secondary nodes now can keep track of replication status and recover
-automatically from some replication issues. To get this feature enabled,
-you need to activate the Tracking Database.
-
-> **IMPORTANT:** For this feature to work correctly, all nodes must be
-with their clocks synchronized. It is not required for all nodes to be set to
-the same time zone, but when the respective times are converted to UTC time,
-the clocks must be synchronized to within 60 seconds of each other.
-
-1. Setup clock synchronization service in your Linux distro.
-   This can easily be done via any NTP-compatible daemon. For example,
-   here are [instructions for setting up NTP with Ubuntu](https://help.ubuntu.com/lts/serverguide/NTP.html).
-
-1. Edit `/etc/gitlab/gitlab.rb`:
-
-    ```
-    geo_postgresql['enable'] = true
-    ```
-
-1. Create `database_geo.yml` with the information of your secondary PostgreSQL
-   database.  Note that GitLab will set up another database instance separate
-   from the primary, since this is where the secondary will track its internal
-   state:
-
-    ```
-    sudo cp /opt/gitlab/embedded/service/gitlab-rails/config/database_geo.yml.postgresql /opt/gitlab/embedded/service/gitlab-rails/config/database_geo.yml
-    ```
-
-1. Edit the content of `database_geo.yml` in `production:` like the example below:
-    
-   ```yaml
-   #
-   # PRODUCTION
-   #
-   production:
-     adapter: postgresql
-     encoding: unicode
-     database: gitlabhq_geo_production
-     pool: 10
-     username: gitlab_geo
-     # password:
-     host: /var/opt/gitlab/geo-postgresql
-     port: 5431
-    
-   ```
-
-1. Reconfigure GitLab:
-
-    ```
-    sudo gitlab-ctl start
-    sudo gitlab-ctl reconfigure
-    ```
-
-1. Set up the Geo tracking database:
+1. Run database migrations on tracking database
 
     ```
     sudo gitlab-rake geo:db:migrate
     ```
 
+1. Repeat this step for every secondary node
+
 [update]: ../update/README.md

doc/user/project/repository/gpg_signed_commits/index.md

@@ -113,7 +113,7 @@ started:
 1. Use the following command to list the private GPG key you just created:
 
     ```
-    gpg --list-secret-keys mr@robot.sh
+    gpg --list-secret-keys --keyid-format LONG mr@robot.sh
     ```
 
     Replace `mr@robot.sh` with the email address you entered above.
@@ -167,7 +167,7 @@ key to use.
 1. Use the following command to list the private GPG key you just created:
 
     ```
-    gpg --list-secret-keys mr@robot.sh
+    gpg --list-secret-keys --keyid-format LONG mr@robot.sh
     ```
 
     Replace `mr@robot.sh` with the email address you entered above.

ee/app/helpers/ee/boards_helper.rb

@@ -54,5 +54,13 @@ module EE
     def board_sidebar_user_data
       super.merge(group_id: @group&.id)
     end
+
+    def boards_link_text
+      if @project.multiple_issue_boards_available?(current_user)
+        "Boards"
+      else
+        "Board"
+      end
+    end
   end
 end

lib/api/api_guard.rb

@@ -106,6 +106,8 @@ module API
       private
 
       def route_authentication_setting
+        return {} unless respond_to?(:route_setting)
+
         route_setting(:authentication) || {}
       end
 

lib/gitlab/checks/change_access.rb

@@ -177,7 +177,7 @@ module Gitlab
 
       def branch_name_allowed_by_push_rule?(push_rule)
         return true unless push_rule
-        return true if @branch_name.empty?
+        return true if @branch_name.blank?
 
         push_rule.branch_name_allowed?(@branch_name)
       end

lib/tasks/geo.rake

@@ -2,14 +2,28 @@ task spec: ['geo:db:test:prepare']
 
 namespace :geo do
   namespace :db do |ns|
-    %i(drop create setup migrate rollback seed version reset).each do |task_name|
+    {
+      drop: 'Drops the Geo tracking database from config/database_geo.yml for the current RAILS_ENV.',
+      create: 'Creates the Geo tracking database from config/database_geo.yml for the current RAILS_ENV.',
+      setup: 'Create the Geo tracking database, load the schema, and initialize with the seed data.',
+      migrate: 'Migrate the Geo tracking database (options: VERSION=x, VERBOSE=false, SCOPE=blog).',
+      rollback: 'Rolls the schema back to the previous version (specify steps w/ STEP=n).',
+      seed: 'Load the seed data from db/geo/seeds.rb',
+      version: 'Retrieves the current schema version number.',
+      reset: 'Drops and recreates the database from db/geo/schema.rb for the current environment and loads the seeds.'
+    }.each do |task_name, task_desc|
+      desc task_desc
       task task_name do
         Rake::Task["db:#{task_name}"].invoke
       end
     end
 
     namespace :schema do
-      %i(load dump).each do |task_name|
+      {
+        load: 'Load a db/geo/schema.rb file into the database',
+        dump: 'Create a db/geo/schema.rb file that is portable against any DB supported by AR.'
+      }.each do |task_name, task_desc|
+        desc task_desc
         task task_name do
           Rake::Task["db:schema:#{task_name}"].invoke
         end
@@ -17,7 +31,12 @@ namespace :geo do
     end
 
     namespace :migrate do
-      %i(up down redo).each do |task_name|
+      {
+        up: 'Runs the "up" for a given migration VERSION.',
+        down: 'Runs the "down" for a given migration VERSION.',
+        redo: 'Rollbacks the database one migration and re migrate up (options: STEP=x, VERSION=x).'
+      }.each do |task_name, task_desc|
+        desc task_desc
         task task_name do
           Rake::Task["db:migrate:#{task_name}"].invoke
         end
@@ -25,6 +44,7 @@ namespace :geo do
     end
 
     namespace :test do
+      desc 'Check for pending migrations and load the test schema'
       task :prepare do
         Rake::Task['db:test:prepare'].invoke
       end

spec/controllers/groups/billings_controller_spec.rb

@@ -7,7 +7,7 @@ describe Groups::BillingsController do
   describe 'GET index' do
     before do
       stub_application_setting(check_namespace_plan: true)
-      allow(Gitlab).to receive(:com?) { true }
+      allow(Gitlab).to receive(:dev_env_or_com?) { true }
     end
 
     context 'authorized' do
@@ -46,7 +46,7 @@ describe Groups::BillingsController do
       end
 
       it 'renders 404 when it is not gitlab.com' do
-        allow(Gitlab).to receive(:com?) { false }
+        allow(Gitlab).to receive(:dev_env_or_com?) { false }
         group.add_owner(user)
         sign_in(user)
 

spec/lib/gitlab/checks/change_access_spec.rb

@@ -249,6 +249,14 @@ describe Gitlab::Checks::ChangeAccess do
           expect { subject }.to raise_error(Gitlab::GitAccess::UnauthorizedError, "Branch name does not follow the pattern '^(w*)$'")
         end
 
+        context 'when the ref is not a branch ref' do
+          let(:ref) { 'a/ref/thats/not/abranch' }
+
+          it 'allows the creation' do
+            expect { subject }.not_to raise_error
+          end
+        end
+
         context 'when no commits are present' do
           before do
             allow(project.repository).to receive(:new_commits) { [] }

spec/models/geo_node_status_spec.rb

@@ -104,6 +104,13 @@ describe GeoNodeStatus do
 
       expect(subject.db_replication_lag).to eq(1000)
     end
+
+    it "doesn't attempt to set replication lag if primary" do
+      expect(Gitlab::Geo::HealthCheck).not_to receive(:db_replication_lag)
+      expect(Gitlab::Geo).to receive(:secondary?).and_return(false)
+
+      expect(subject.db_replication_lag).to eq(nil)
+    end
   end
 
   describe '#lfs_objects_synced_in_percentage' do
@@ -196,6 +203,14 @@ describe GeoNodeStatus do
 
       expect(subject.cursor_last_event_id).to eq(event.event_id)
     end
+
+    it "doesn't attempt to retrieve cursor if primary" do
+      create(:geo_event_log_state)
+      expect(Gitlab::Geo).to receive(:secondary?).exactly(2).times.and_return(false)
+
+      expect(subject.cursor_last_event_date).to eq(nil)
+      expect(subject.cursor_last_event_id).to eq(nil)
+    end
   end
 
   context 'when no values are available' do

spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb

 require 'spec_helper'
 
 describe 'layouts/nav/sidebar/_project' do
+  let(:project) { create(:project, :repository) }
+
+  before do
+    assign(:project, project)
+    assign(:repository, project.repository)
+    allow(view).to receive(:current_ref).and_return('master')
+
+    allow(view).to receive(:can?).and_return(true)
+  end
+
+  describe 'issue boards' do
+    it 'has boards tab when multiple issue boards available' do
+      render
+
+      expect(rendered).to have_css('a[title="Boards"]')
+    end
+
+    it 'has board tab when multiple issue boards is not available' do
+      allow(License).to receive(:feature_available?).and_call_original
+      allow(License).to receive(:feature_available?).with(:multiple_issue_boards) { false }
+
+      render
+
+      expect(rendered).to have_css('a[title="Board"]')
+    end
+  end
+
   describe 'container registry tab' do
     before do
-      project = create(:project, :repository)
       stub_container_registry_config(enabled: true)
 
-      assign(:project, project)
-      assign(:repository, project.repository)
-      allow(view).to receive(:current_ref).and_return('master')
-
-      allow(view).to receive(:can?).and_return(true)
       allow(controller).to receive(:controller_name)
         .and_return('repositories')
       allow(controller).to receive(:controller_path)