Merge branch '284597-remove-bootstrap-4-s-cards-components-from-dashboard-todos' into 'master'

Remove Bootstrap 4's Cards components from Issuables and Todos

See merge request gitlab-org/gitlab!48004

app/assets/stylesheets/bootstrap_migration.scss

@@ -235,10 +235,6 @@ h3.popover-header {
     @extend .border-0;
   }
 
-  &.card-without-margin {
-    margin: 0;
-  }
-
   &.bg-light {
     @extend .border-0;
   }

app/assets/stylesheets/framework/lists.scss

@@ -234,6 +234,8 @@ ul.content-list {
   }
 }
 
+ul.content-list.issuable-list > li,
+ul.content-list.todos-list > li,
 .card > .content-list > li {
   padding: $gl-padding-top $gl-padding;
 }

app/views/dashboard/todos/index.html.haml

@@ -85,9 +85,8 @@
   - if @todos.any?
     .js-todos-list-container{ data: { qa_selector: "todos_list_container" } }
       .js-todos-options{ data: { per_page: @todos.limit_value, current_page: @todos.current_page, total_pages: @todos.total_pages } }
-        .card.card-without-border.card-without-margin
-          %ul.content-list.todos-list
-            = render @todos
+        %ul.content-list.todos-list
+          = render @todos
       = paginate @todos, theme: "gitlab"
     .js-nothing-here-container.todos-all-done.hidden.svg-content
       = image_tag 'illustrations/todos_all_done.svg'

app/views/shared/_issues.html.haml

 - if @issues.to_a.any?
-  .card.card-without-border
-    %ul.content-list.issues-list.issuable-list{ class: ("manual-ordering" if @sort == 'relative_position'), data: { group_full_path: @group&.full_path } }
-      = render partial: 'projects/issues/issue', collection: @issues
+  %ul.content-list.issues-list.issuable-list{ class: ("manual-ordering" if @sort == 'relative_position'), data: { group_full_path: @group&.full_path } }
+    = render partial: 'projects/issues/issue', collection: @issues
   = paginate @issues, theme: "gitlab"
 - else
   = render 'shared/empty_states/issues'

app/views/shared/_merge_requests.html.haml

 - if @merge_requests.to_a.any?
-  .card.card-without-border
-    %ul.content-list.mr-list.issuable-list
-      = render partial: 'projects/merge_requests/merge_request', collection: @merge_requests
+  %ul.content-list.mr-list.issuable-list
+    = render partial: 'projects/merge_requests/merge_request', collection: @merge_requests
 
   = paginate @merge_requests, theme: "gitlab"
 

changelogs/unreleased/284597-remove-bootstrap-4-s-cards-components-from-dashboard-todos.yml

+---
+title: Remove Bootstrap 4's Cards components from Issuables and Todos
+merge_request: 48004
+author: Takuya Noguchi
+type: performance