Merge branch 'update-gitlab-styles' into 'master'

Update gitlab-styles to 6.0.0

See merge request gitlab-org/gitlab!51116

Gemfile

@@ -370,7 +370,7 @@ group :development, :test do
   gem 'spring', '~> 2.1.0'
   gem 'spring-commands-rspec', '~> 1.0.4'
 
-  gem 'gitlab-styles', '~> 5.4.0', require: false
+  gem 'gitlab-styles', '~> 6.0.0', require: false
 
   gem 'scss_lint', '~> 0.59.0', require: false
   gem 'haml_lint', '~> 0.36.0', require: false

Gemfile.lock

@@ -447,11 +447,11 @@ GEM
     gitlab-pg_query (1.3.1)
     gitlab-sidekiq-fetcher (0.5.2)
       sidekiq (~> 5)
-    gitlab-styles (5.4.0)
-      rubocop (~> 0.89.1)
-      rubocop-gitlab-security (~> 0.1.0)
-      rubocop-performance (~> 1.8.1)
-      rubocop-rails (~> 2.8)
+    gitlab-styles (6.0.0)
+      rubocop (~> 0.91.1)
+      rubocop-gitlab-security (~> 0.1.1)
+      rubocop-performance (~> 1.9.2)
+      rubocop-rails (~> 2.9)
       rubocop-rspec (~> 1.44)
     gitlab_chronic_duration (0.10.6.2)
       numerizer (~> 0.2)
@@ -591,7 +591,7 @@ GEM
       mime-types (~> 3.0)
       multi_xml (>= 0.5.2)
     httpclient (2.8.3)
-    i18n (1.8.5)
+    i18n (1.8.7)
       concurrent-ruby (~> 1.0)
     i18n_data (0.8.0)
     icalendar (2.4.1)
@@ -836,8 +836,8 @@ GEM
       rubypants (~> 0.2)
     orm_adapter (0.5.0)
     os (1.1.1)
-    parallel (1.19.2)
-    parser (2.7.2.0)
+    parallel (1.20.1)
+    parser (3.0.0.0)
       ast (~> 2.4.1)
     parslet (1.8.2)
     peek (1.1.0)
@@ -1028,26 +1028,26 @@ GEM
       pg
       rails
       sqlite3
-    rubocop (0.89.1)
+    rubocop (0.91.1)
       parallel (~> 1.10)
       parser (>= 2.7.1.1)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.7)
       rexml
-      rubocop-ast (>= 0.3.0, < 1.0)
+      rubocop-ast (>= 0.4.0, < 1.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 2.0)
     rubocop-ast (0.8.0)
       parser (>= 2.7.1.5)
     rubocop-gitlab-security (0.1.1)
       rubocop (>= 0.51)
-    rubocop-performance (1.8.1)
-      rubocop (>= 0.87.0)
+    rubocop-performance (1.9.2)
+      rubocop (>= 0.90.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.8.1)
+    rubocop-rails (2.9.1)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
-      rubocop (>= 0.87.0)
+      rubocop (>= 0.90.0, < 2.0)
     rubocop-rspec (1.44.1)
       rubocop (~> 0.87)
       rubocop-ast (>= 0.7.1)
@@ -1056,7 +1056,7 @@ GEM
     ruby-fogbugz (0.2.1)
       crack (~> 0.4)
     ruby-prof (1.3.1)
-    ruby-progressbar (1.10.1)
+    ruby-progressbar (1.11.0)
     ruby-saml (1.7.2)
       nokogiri (>= 1.5.10)
     ruby-statistics (2.1.2)
@@ -1364,7 +1364,7 @@ DEPENDENCIES
   gitlab-markup (~> 1.7.1)
   gitlab-net-dns (~> 0.9.1)
   gitlab-sidekiq-fetcher (= 0.5.2)
-  gitlab-styles (~> 5.4.0)
+  gitlab-styles (~> 6.0.0)
   gitlab_chronic_duration (~> 0.10.6.2)
   gitlab_omniauth-ldap (~> 2.1.1)
   gon (~> 6.2)

app/finders/autocomplete/group_finder.rb

@@ -27,8 +27,7 @@ module Autocomplete
       # This removes the need for using `return render_404` and similar patterns
       # in controllers that use this finder.
       unless Ability.allowed?(current_user, :read_group, group)
-        raise ActiveRecord::RecordNotFound
-          .new("Could not find a Group with ID #{group_id}")
+        raise ActiveRecord::RecordNotFound, "Could not find a Group with ID #{group_id}"
       end
 
       group

app/finders/autocomplete/project_finder.rb

@@ -25,8 +25,7 @@ module Autocomplete
       # This removes the need for using `return render_404` and similar patterns
       # in controllers that use this finder.
       unless Ability.allowed?(current_user, :read_project, project)
-        raise ActiveRecord::RecordNotFound
-          .new("Could not find a Project with ID #{project_id}")
+        raise ActiveRecord::RecordNotFound, "Could not find a Project with ID #{project_id}"
       end
 
       project

app/finders/concerns/finder_methods.rb

@@ -22,7 +22,7 @@ module FinderMethods
   def raise_not_found_unless_authorized(result)
     result = if_authorized(result)
 
-    raise ActiveRecord::RecordNotFound.new("Couldn't find #{model}") unless result
+    raise(ActiveRecord::RecordNotFound, "Couldn't find #{model}") unless result
 
     result
   end

app/models/concerns/bulk_insert_safe.rb

@@ -53,9 +53,9 @@ module BulkInsertSafe
   class_methods do
     def set_callback(name, *args)
       unless _bulk_insert_callback_allowed?(name, args)
-        raise MethodNotAllowedError.new(
+        raise MethodNotAllowedError,
           "Not allowed to call `set_callback(#{name}, #{args})` when model extends `BulkInsertSafe`." \
-            "Callbacks that fire per each record being inserted do not work with bulk-inserts.")
+            "Callbacks that fire per each record being inserted do not work with bulk-inserts."
       end
 
       super

rubocop/cop/rspec/expect_gitlab_tracking.rb

@@ -53,8 +53,6 @@ module RuboCop
           )
         PATTERN
 
-        RESTRICT_ON_SEND = [:expect, :allow].freeze
-
         def on_send(node)
           return unless expect_gitlab_tracking?(node)