Transition from Engineering Productivity to tooling label in Danger

Signed-off-by: Rémy Coutable <remy@rymai.me>

Gemfile

@@ -394,7 +394,7 @@ group :development, :test do
 end
 
 group :development, :test, :danger do
-  gem 'gitlab-dangerfiles', '~> 2.2.2', require: false
+  gem 'gitlab-dangerfiles', '~> 2.3.0', require: false
 end
 
 group :development, :test, :coverage do

Gemfile.lock

@@ -460,7 +460,7 @@ GEM
       terminal-table (~> 1.5, >= 1.5.1)
     gitlab-chronic (0.10.5)
       numerizer (~> 0.2)
-    gitlab-dangerfiles (2.2.2)
+    gitlab-dangerfiles (2.3.0)
       danger (>= 8.3.1)
       danger-gitlab (>= 8.0.0)
     gitlab-experiment (0.6.2)
@@ -1467,7 +1467,7 @@ DEPENDENCIES
   gitaly (~> 14.1.0.pre.rc4)
   github-markup (~> 1.7.0)
   gitlab-chronic (~> 0.10.5)
-  gitlab-dangerfiles (~> 2.2.2)
+  gitlab-dangerfiles (~> 2.3.0)
   gitlab-experiment (~> 0.6.2)
   gitlab-fog-azure-rm (~> 1.1.1)
   gitlab-labkit (~> 0.21.0)

danger/specialization_labels/Dangerfile

@@ -8,7 +8,7 @@ SPECIALIZATIONS = {
   frontend: 'frontend',
   docs: 'documentation',
   qa: 'QA',
-  engineering_productivity: 'Engineering Productivity',
+  tooling: 'tooling',
   ci_template: 'ci::templates',
   feature_flag: 'feature flag'
 }.freeze

spec/tooling/danger/project_helper_spec.rb

@@ -77,7 +77,7 @@ RSpec.describe Tooling::Danger::ProjectHelper do
       'ee/spec/frontend/bar'             | [:frontend]
       'ee/spec/frontend_integration/bar' | [:frontend]
 
-      '.gitlab/ci/frontend.gitlab-ci.yml' | %i[frontend engineering_productivity]
+      '.gitlab/ci/frontend.gitlab-ci.yml' | %i[frontend tooling]
 
       'app/models/foo'             | [:backend]
       'bin/foo'                    | [:backend]
@@ -113,22 +113,22 @@ RSpec.describe Tooling::Danger::ProjectHelper do
       'Rakefile'       | [:backend]
       'FOO_VERSION'    | [:backend]
 
-      'Dangerfile'                                            | [:engineering_productivity]
-      'danger/bundle_size/Dangerfile'                         | [:engineering_productivity]
-      'ee/danger/bundle_size/Dangerfile'                      | [:engineering_productivity]
-      'danger/bundle_size/'                                   | [:engineering_productivity]
-      'ee/danger/bundle_size/'                                | [:engineering_productivity]
-      '.gitlab-ci.yml'                                        | [:engineering_productivity]
-      '.gitlab/ci/cng.gitlab-ci.yml'                          | [:engineering_productivity]
-      '.gitlab/ci/ee-specific-checks.gitlab-ci.yml'           | [:engineering_productivity]
-      'scripts/foo'                                           | [:engineering_productivity]
-      'tooling/danger/foo'                                    | [:engineering_productivity]
-      'ee/tooling/danger/foo'                                 | [:engineering_productivity]
-      'lefthook.yml'                                          | [:engineering_productivity]
-      '.editorconfig'                                         | [:engineering_productivity]
-      'tooling/bin/find_foss_tests'                           | [:engineering_productivity]
-      '.codeclimate.yml'                                      | [:engineering_productivity]
-      '.gitlab/CODEOWNERS'                                    | [:engineering_productivity]
+      'Dangerfile'                                            | [:tooling]
+      'danger/bundle_size/Dangerfile'                         | [:tooling]
+      'ee/danger/bundle_size/Dangerfile'                      | [:tooling]
+      'danger/bundle_size/'                                   | [:tooling]
+      'ee/danger/bundle_size/'                                | [:tooling]
+      '.gitlab-ci.yml'                                        | [:tooling]
+      '.gitlab/ci/cng.gitlab-ci.yml'                          | [:tooling]
+      '.gitlab/ci/ee-specific-checks.gitlab-ci.yml'           | [:tooling]
+      'scripts/foo'                                           | [:tooling]
+      'tooling/danger/foo'                                    | [:tooling]
+      'ee/tooling/danger/foo'                                 | [:tooling]
+      'lefthook.yml'                                          | [:tooling]
+      '.editorconfig'                                         | [:tooling]
+      'tooling/bin/find_foss_tests'                           | [:tooling]
+      '.codeclimate.yml'                                      | [:tooling]
+      '.gitlab/CODEOWNERS'                                    | [:tooling]
 
       'lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml'   | [:ci_template]
       'lib/gitlab/ci/templates/dotNET-Core.yml'               | [:ci_template]

tooling/danger/project_helper.rb

@@ -74,7 +74,7 @@ module Tooling
 
         %r{(\A|/)(
           \.gitlab/ci/frontend\.gitlab-ci\.yml
-        )\z}x => %i[frontend engineering_productivity],
+        )\z}x => %i[frontend tooling],
 
         %r{\A(ee/)?db/(geo/)?(migrate|post_migrate)/} => [:database, :migration],
         %r{\A(ee/)?db/(?!fixtures)[^/]+} => [:database],
@@ -84,16 +84,16 @@ module Tooling
         %r{\A(ee/)?app/finders/} => [:database, :backend],
         %r{\Arubocop/cop/migration(/|\.rb)} => :database,
 
-        %r{\A(\.gitlab-ci\.yml\z|\.gitlab\/ci)} => :engineering_productivity,
-        %r{\A\.codeclimate\.yml\z} => :engineering_productivity,
-        %r{\Alefthook.yml\z} => :engineering_productivity,
-        %r{\A\.editorconfig\z} => :engineering_productivity,
-        %r{Dangerfile\z} => :engineering_productivity,
-        %r{\A(ee/)?(danger/|tooling/danger/)} => :engineering_productivity,
-        %r{\A(ee/)?scripts/} => :engineering_productivity,
-        %r{\Atooling/} => :engineering_productivity,
-        %r{(CODEOWNERS)} => :engineering_productivity,
-        %r{(tests.yml)} => :engineering_productivity,
+        %r{\A(\.gitlab-ci\.yml\z|\.gitlab\/ci)} => :tooling,
+        %r{\A\.codeclimate\.yml\z} => :tooling,
+        %r{\Alefthook.yml\z} => :tooling,
+        %r{\A\.editorconfig\z} => :tooling,
+        %r{Dangerfile\z} => :tooling,
+        %r{\A(ee/)?(danger/|tooling/danger/)} => :tooling,
+        %r{\A(ee/)?scripts/} => :tooling,
+        %r{\Atooling/} => :tooling,
+        %r{(CODEOWNERS)} => :tooling,
+        %r{(tests.yml)} => :tooling,
 
         %r{\Alib/gitlab/ci/templates} => :ci_template,