Merge branch 'jj-remove-caching-experiments' into 'master'

Remove caching_experiments feature flag [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!53901

app/experiments/application_experiment.rb

@@ -108,7 +108,6 @@ class ApplicationExperiment < Gitlab::Experiment # rubocop:disable Gitlab/Namesp
     end
 
     def write_entry(key, entry, **options)
-      return false unless Feature.enabled?(:caching_experiments)
       return false if entry.value.blank? # don't cache any empty values
 
       pool { |redis| redis.hset(*hkey(key), entry.value) }

changelogs/unreleased/jj-remove-caching-experiments.yml

+---
+title: Remove caching_experiments feature flag
+merge_request: 53901
+author:
+type: other

config/feature_flags/development/caching_experiments.yml

----
-name: caching_experiments
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/49669
-rollout_issue_url: 
-milestone: '13.7'
-type: development
-group: group::adoption
-default_enabled: false

spec/experiments/application_experiment/cache_spec.rb

@@ -51,16 +51,4 @@ RSpec.describe ApplicationExperiment::Cache do
       'invalid call to clear a non-hash cache key'
     )
   end
-
-  context "when the :caching_experiments feature is disabled" do
-    before do
-      stub_feature_flags(caching_experiments: false)
-    end
-
-    it "doesn't write to the cache" do
-      subject.write(key_field, 'value')
-
-      expect(subject.read(key_field)).to be_nil
-    end
-  end
 end