Commit c3ea049e authored by Nathan Friend's avatar Nathan Friend

Avoid making API requests when paths are invalid

This commit updates the error handling logic to avoid making an API
request if the provided project/group paths are invalid.
parent 7cca97ce
...@@ -53,7 +53,9 @@ export default { ...@@ -53,7 +53,9 @@ export default {
}, },
}, },
async mounted() { async mounted() {
this.checkProvidedPaths(); if (!this.checkProvidedPaths()) {
return;
}
const results = await Promise.allSettled( const results = await Promise.allSettled(
allChartDefinitions.map(async ({ id, requestParams, startDate, endDate }) => { allChartDefinitions.map(async ({ id, requestParams, startDate, endDate }) => {
...@@ -98,6 +100,8 @@ export default { ...@@ -98,6 +100,8 @@ export default {
* Validates that exactly one of [this.projectPath, this.groupPath] has been * Validates that exactly one of [this.projectPath, this.groupPath] has been
* provided to this component. If not, a flash message is shown and an error * provided to this component. If not, a flash message is shown and an error
* is logged with Sentry. This is mainly intended to be a development aid. * is logged with Sentry. This is mainly intended to be a development aid.
* @returns {Boolean} Whether or not the paths are valid
*/ */
checkProvidedPaths() { checkProvidedPaths() {
let errorMessage = ''; let errorMessage = '';
...@@ -116,7 +120,11 @@ export default { ...@@ -116,7 +120,11 @@ export default {
error: new Error(`Error while rendering lead time charts: ${errorMessage}`), error: new Error(`Error while rendering lead time charts: ${errorMessage}`),
captureError: true, captureError: true,
}); });
return false;
} }
return true;
}, },
}, },
areaChartOptions, areaChartOptions,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment