Commit c4e45d89 authored by Kamil Trzcinski's avatar Kamil Trzcinski

Fix remaining offenses

parent ad859287
...@@ -32,7 +32,7 @@ feature 'Widget Deployments Header', feature: true, js: true do ...@@ -32,7 +32,7 @@ feature 'Widget Deployments Header', feature: true, js: true do
given(:manual) { create(:ci_build, :manual, pipeline: pipeline, name: 'close_app') } given(:manual) { create(:ci_build, :manual, pipeline: pipeline, name: 'close_app') }
given(:deployment) do given(:deployment) do
create(:deployment, environment: environment, ref: merge_request.target_branch, create(:deployment, environment: environment, ref: merge_request.target_branch,
sha: sha, deployable: build, on_stop: 'close_app') sha: sha, deployable: build, on_stop: 'close_app')
end end
background do background do
......
...@@ -150,8 +150,8 @@ describe Environment, models: true do ...@@ -150,8 +150,8 @@ describe Environment, models: true do
let!(:close_action) { create(:ci_build, :manual, pipeline: build.pipeline, name: 'close_app') } let!(:close_action) { create(:ci_build, :manual, pipeline: build.pipeline, name: 'close_app') }
it 'returns the same action' do it 'returns the same action' do
is_expected.to eq(close_action) expect(subject).to eq(close_action)
is_expected.to include(user: user) expect(subject.user).to eq(user)
end end
end end
...@@ -160,7 +160,8 @@ describe Environment, models: true do ...@@ -160,7 +160,8 @@ describe Environment, models: true do
it 'returns a new action of the same type' do it 'returns a new action of the same type' do
is_expected.to be_persisted is_expected.to be_persisted
is_expected.to include(name: close_action.name, user: user) expect(subject.name).to eq(close_action.name)
expect(subject.user).to eq(user)
end end
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment