Merge branch 'refactoring-entities-file-18' into 'master'

Add list, board, broadcast message, contributor and compare into own class files

See merge request gitlab-org/gitlab!24939

changelogs/unreleased/refactoring-entities-file-18.yml

+---
+title: Separate board, list and other entities into own class files
+merge_request: 24939
+author: Rajendra Kadam
+type: added

lib/api/entities.rb

@@ -163,49 +163,6 @@ module API
       end
     end
 
-    class List < Grape::Entity
-      expose :id
-      expose :label, using: Entities::LabelBasic
-      expose :position
-    end
-
-    class Board < Grape::Entity
-      expose :id
-      expose :project, using: Entities::BasicProjectDetails
-
-      expose :lists, using: Entities::List do |board|
-        board.destroyable_lists
-      end
-    end
-
-    class Compare < Grape::Entity
-      expose :commit, using: Entities::Commit do |compare, _|
-        compare.commits.last
-      end
-
-      expose :commits, using: Entities::Commit do |compare, _|
-        compare.commits
-      end
-
-      expose :diffs, using: Entities::Diff do |compare, _|
-        compare.diffs.diffs.to_a
-      end
-
-      expose :compare_timeout do |compare, _|
-        compare.diffs.diffs.overflow?
-      end
-
-      expose :same, as: :compare_same_ref
-    end
-
-    class Contributor < Grape::Entity
-      expose :name, :email, :commits, :additions, :deletions
-    end
-
-    class BroadcastMessage < Grape::Entity
-      expose :message, :starts_at, :ends_at, :color, :font, :target_path, :broadcast_type
-    end
-
     class Trigger < Grape::Entity
       include ::API::Helpers::Presentable
 

lib/api/entities/board.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class Board < Grape::Entity
+      expose :id
+      expose :project, using: Entities::BasicProjectDetails
+
+      expose :lists, using: Entities::List do |board|
+        board.destroyable_lists
+      end
+    end
+  end
+end

lib/api/entities/broadcast_message.rb

@@ -3,7 +3,7 @@
 module API
   module Entities
     class BroadcastMessage < Grape::Entity
-      expose :id, :message, :starts_at, :ends_at, :color, :font
+      expose :id, :message, :starts_at, :ends_at, :color, :font, :target_path, :broadcast_type
       expose :active?, as: :active
     end
   end

lib/api/entities/compare.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class Compare < Grape::Entity
+      expose :commit, using: Entities::Commit do |compare, _|
+        compare.commits.last
+      end
+
+      expose :commits, using: Entities::Commit do |compare, _|
+        compare.commits
+      end
+
+      expose :diffs, using: Entities::Diff do |compare, _|
+        compare.diffs.diffs.to_a
+      end
+
+      expose :compare_timeout do |compare, _|
+        compare.diffs.diffs.overflow?
+      end
+
+      expose :same, as: :compare_same_ref
+    end
+  end
+end

lib/api/entities/contributor.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class Contributor < Grape::Entity
+      expose :name, :email, :commits, :additions, :deletions
+    end
+  end
+end

lib/api/entities/list.rb

+# frozen_string_literal: true
+
+module API
+  module Entities
+    class List < Grape::Entity
+      expose :id
+      expose :label, using: Entities::LabelBasic
+      expose :position
+    end
+  end
+end