Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
c58409e8
Commit
c58409e8
authored
Oct 07, 2020
by
Adam Hegyi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove store_instance_statistics_measurements FF
parent
59ff37b8
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
5 additions
and
21 deletions
+5
-21
app/workers/analytics/instance_statistics/count_job_trigger_worker.rb
...analytics/instance_statistics/count_job_trigger_worker.rb
+0
-2
changelogs/unreleased/remove_store_instance_statistics_measurements_ff.yml
...ased/remove_store_instance_statistics_measurements_ff.yml
+5
-0
config/feature_flags/development/store_instance_statistics_measurements.yml
...gs/development/store_instance_statistics_measurements.yml
+0
-7
spec/workers/analytics/instance_statistics/count_job_trigger_worker_spec.rb
...tics/instance_statistics/count_job_trigger_worker_spec.rb
+0
-12
No files found.
app/workers/analytics/instance_statistics/count_job_trigger_worker.rb
View file @
c58409e8
...
...
@@ -14,8 +14,6 @@ module Analytics
idempotent!
def
perform
return
if
Feature
.
disabled?
(
:store_instance_statistics_measurements
,
default_enabled:
true
)
recorded_at
=
Time
.
zone
.
now
worker_arguments
=
Gitlab
::
Analytics
::
InstanceStatistics
::
WorkersArgumentBuilder
.
new
(
...
...
changelogs/unreleased/remove_store_instance_statistics_measurements_ff.yml
0 → 100644
View file @
c58409e8
---
title
:
Remove the `store_instance_statistics_measurements` feature flag
merge_request
:
44566
author
:
type
:
changed
config/feature_flags/development/store_instance_statistics_measurements.yml
deleted
100644 → 0
View file @
59ff37b8
---
name
:
store_instance_statistics_measurements
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/41300
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/247871
group
:
group::analytics
type
:
development
default_enabled
:
true
spec/workers/analytics/instance_statistics/count_job_trigger_worker_spec.rb
View file @
c58409e8
...
...
@@ -14,16 +14,4 @@ RSpec.describe Analytics::InstanceStatistics::CountJobTriggerWorker do
expect
(
Analytics
::
InstanceStatistics
::
CounterJobWorker
.
jobs
.
count
).
to
eq
(
expected_count
)
end
end
context
'when the `store_instance_statistics_measurements` feature flag is off'
do
before
do
stub_feature_flags
(
store_instance_statistics_measurements:
false
)
end
it
'does not trigger any CounterJobWorker job'
do
subject
.
perform
expect
(
Analytics
::
InstanceStatistics
::
CounterJobWorker
.
jobs
.
count
).
to
eq
(
0
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment