Don't show keep path for non archive artifacts

Non archive artifacts are not keepable so don't return
the keep_path for them.

app/models/ci/build.rb

@@ -721,6 +721,10 @@ module Ci
       artifacts_expire_at.present? && artifacts_expire_at > Time.now
     end
 
+    def has_expiring_archive_artifacts?
+      has_expiring_artifacts? && artifacts_file&.exists?
+    end
+
     def keep_artifacts!
       self.update(artifacts_expire_at: nil)
       self.job_artifacts.update_all(expire_at: nil)

app/serializers/build_details_entity.rb

@@ -31,7 +31,7 @@ class BuildDetailsEntity < JobEntity
       browse_project_job_artifacts_path(project, build)
     end
 
-    expose :keep_path, if: -> (*) { build.has_expiring_artifacts? && can?(current_user, :update_build, build) } do |build|
+    expose :keep_path, if: -> (*) { build.has_expiring_archive_artifacts? && can?(current_user, :update_build, build) } do |build|
       keep_project_job_artifacts_path(project, build)
     end
 

changelogs/unreleased/eb-no-keep-report-artifacts.yml

+---
+title: Remove keep button for non archive artifacts
+merge_request: 21553
+author:
+type: fixed

spec/models/ci/build_spec.rb

@@ -2246,6 +2246,38 @@ describe Ci::Build do
     end
   end
 
+  describe '#has_expiring_archive_artifacts?' do
+    context 'when artifacts have expiration date set' do
+      before do
+        build.update(artifacts_expire_at: 1.day.from_now)
+      end
+
+      context 'and job artifacts file exists' do
+        let!(:archive) { create(:ci_job_artifact, :archive, job: build) }
+
+        it 'has expiring artifacts' do
+          expect(build).to have_expiring_archive_artifacts
+        end
+      end
+
+      context 'and job artifacts file does not exist' do
+        it 'does not have expiring artifacts' do
+          expect(build).not_to have_expiring_archive_artifacts
+        end
+      end
+    end
+
+    context 'when artifacts do not have expiration date set' do
+      before do
+        build.update(artifacts_expire_at: nil)
+      end
+
+      it 'does not have expiring artifacts' do
+        expect(build).not_to have_expiring_archive_artifacts
+      end
+    end
+  end
+
   describe '#variables' do
     let(:container_registry_enabled) { false }
 

spec/serializers/build_details_entity_spec.rb

@@ -176,5 +176,27 @@ describe BuildDetailsEntity do
         expect(subject[:reports].first[:file_type]).to eq('codequality')
       end
     end
+
+    context 'when the build has no archive type artifacts' do
+      let!(:report) { create(:ci_job_artifact, :codequality, job: build) }
+
+      it 'does not expose any artifact actions path' do
+        expect(subject[:artifact].keys).not_to include(:download_path, :browse_path, :keep_path)
+      end
+    end
+
+    context 'when the build has archive type artifacts' do
+      let!(:report) { create(:ci_job_artifact, :codequality, job: build) }
+      let!(:archive) { create(:ci_job_artifact, :archive, job: build) }
+      let!(:metadata) { create(:ci_job_artifact, :metadata, job: build) }
+
+      before do
+        build.update(artifacts_expire_at: 7.days.from_now)
+      end
+
+      it 'exposes artifact details' do
+        expect(subject[:artifact].keys).to include(:download_path, :browse_path, :keep_path, :expire_at, :expired)
+      end
+    end
   end
 end