Use map in sprintf instead of bracket notation

c9db4820 · Ammar Alakkad · Vitaly Slobodin · 7316c9a7 · c9db4820
Commit c9db4820 authored May 24, 2021 by Ammar Alakkad Committed by Vitaly Slobodin May 24, 2021
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 2 deletions

app/assets/javascripts/locale/sprintf.js app/assets/javascripts/locale/sprintf.js +4 -2

No files found.
--- a/app/assets/javascripts/locale/sprintf.js
+++ b/app/assets/javascripts/locale/sprintf.js
@@ -15,8 +15,10 @@ export default (input, parameters, escapeParameters = true) => {
  let output = input;

  if (parameters) {
-    Object.keys(parameters).forEach((parameterName) => {
-      const parameterValue = parameters[parameterName];
+    const mappedParameters = new Map(Object.entries(parameters));
+
+    mappedParameters.forEach((key, parameterName) => {
+      const parameterValue = mappedParameters.get(parameterName);
      const escapedParameterValue = escapeParameters ? escape(parameterValue) : parameterValue;
      output = output.replace(new RegExp(`%{${parameterName}}`, 'g'), escapedParameterValue);
    });