Extract method to make intention clearer

ee/app/services/software_license_policies/create_service.rb

@@ -21,15 +21,17 @@ module SoftwareLicensePolicies
     private
 
     def create_software_license_policy
-      approval_status = params[:approval_status]
-      classification = SoftwareLicensePolicy::APPROVAL_STATUS.fetch(approval_status, approval_status)
       policy = SoftwareLicense.create_policy_for!(
         project: project,
         name: params[:name],
-        classification: classification
+        classification: map_from(params[:approval_status])
       )
       RefreshLicenseComplianceChecksWorker.perform_async(project.id)
       policy
     end
+
+    def map_from(approval_status)
+      SoftwareLicensePolicy::APPROVAL_STATUS.fetch(approval_status, approval_status)
+    end
   end
 end

ee/app/services/software_license_policies/update_service.rb

@@ -12,9 +12,7 @@ module SoftwareLicensePolicies
       return success(software_license_policy: software_license_policy) unless params[:approval_status].present?
 
       begin
-        approval_status = params[:approval_status]
-        classification = SoftwareLicensePolicy::APPROVAL_STATUS.fetch(approval_status, approval_status)
-        software_license_policy.update(classification: classification)
+        software_license_policy.update(classification: map_from(params[:approval_status]))
         RefreshLicenseComplianceChecksWorker.perform_async(project.id)
       rescue ArgumentError => ex
         return error(ex.message, 400)
@@ -22,5 +20,11 @@ module SoftwareLicensePolicies
 
       success(software_license_policy: software_license_policy)
     end
+
+    private
+
+    def map_from(approval_status)
+      SoftwareLicensePolicy::APPROVAL_STATUS.fetch(approval_status, approval_status)
+    end
   end
 end