Merge branch 'qa-ml-do-not-skip-login-page-check' into 'master'

[QA] Don't skip the login page check

See merge request gitlab-org/gitlab-ee!10414

qa/qa/ee/strategy.rb

@@ -8,15 +8,14 @@ module QA
       end
 
       def perform_before_hooks
-        return unless ENV['EE_LICENSE']
+        # The login page could take some time to load the first time it is visited.
+        # We visit the login page and wait for it to properly load only once before the tests.
+        QA::Runtime::Browser.visit(:gitlab, QA::Page::Main::Login)
+        QA::Page::Main::Login.perform(&:assert_page_loaded)
 
-        QA::Runtime::Browser.visit(:gitlab, QA::Page::Main::Login) do
-          # The login page could take some time to load the first time it is visited.
-          # We visit the login page and wait for it to properly load only once before the tests.
-          QA::Page::Main::Login.perform(&:assert_page_loaded)
+        return unless ENV['EE_LICENSE']
 
-          EE::Resource::License.fabricate!(ENV['EE_LICENSE'])
-        end
+        EE::Resource::License.fabricate!(ENV['EE_LICENSE'])
       end
     end
   end