Merge branch '212905-make-active_users-param-in-syncseatlinkrequestworker-mandatory' into 'master'

Mandatory active_users param for SyncSeatLinkRequestWorker#perform

Closes #212905

See merge request gitlab-org/gitlab!30810

ee/app/workers/sync_seat_link_request_worker.rb

@@ -12,10 +12,7 @@ class SyncSeatLinkRequestWorker
 
   RequestError = Class.new(StandardError)
 
-  # active_users param is optional as it was added in a patch release for %12.9.
-  # The optional nil value can be removed in the next major release, %13.0, when
-  # it becomes mandatory.
-  def perform(date, license_key, max_historical_user_count, active_users = nil)
+  def perform(date, license_key, max_historical_user_count, active_users)
     response = Gitlab::HTTP.post(
       URI_PATH,
       base_uri: EE::SUBSCRIPTIONS_URL,

ee/changelogs/unreleased/212905-make-active_users-param-in-syncseatlinkrequestworker-mandatory.yml

+---
+title: Make active_users param mandatory for SyncSeatLinkRequestWorker#perform
+merge_request: 30810
+author:
+type: other

ee/spec/workers/sync_seat_link_request_worker_spec.rb

@@ -43,29 +43,5 @@ describe SyncSeatLinkRequestWorker, type: :worker do
     end
 
     it_behaves_like 'unsuccessful request'
-
-    context 'when the active_users param is not passed' do
-      subject do
-        described_class.new.perform('2020-01-01', '123', 5)
-      end
-
-      it 'still processes the job and sends a request with active_users set to nil' do
-        stub_request(:post, seat_link_url).to_return(status: 200)
-
-        subject
-
-        expect(WebMock).to have_requested(:post, seat_link_url).with(
-          headers: { 'Content-Type' => 'application/json' },
-          body: {
-            date: '2020-01-01',
-            license_key: '123',
-            max_historical_user_count: 5,
-            active_users: nil
-          }.to_json
-        )
-      end
-
-      it_behaves_like 'unsuccessful request'
-    end
   end
 end