Refactored expand_section to use name instead of selector

Removed previously added class elements

app/views/projects/deploy_keys/_index.html.haml

 - expanded = Rails.env.test?
-%section.settings.repository-deploy-keys.no-animate{ class: ('expanded' if expanded) }
+%section.settings.no-animate{ class: ('expanded' if expanded) }
   .settings-header
     %h4
       Deploy Keys

app/views/projects/protected_branches/shared/_index.html.haml

 - expanded = Rails.env.test?
 
-%section.settings.project-protected-branches.no-animate{ class: ('expanded' if expanded) }
+%section.settings.no-animate{ class: ('expanded' if expanded) }
   .settings-header
     %h4
       Protected Branches

app/views/projects/protected_tags/shared/_index.html.haml

 - expanded = Rails.env.test?
 
-%section.settings.project-protected-tags.no-animate{ class: ('expanded' if expanded) }
+%section.settings.no-animate{ class: ('expanded' if expanded) }
   .settings-header
     %h4
       Protected Tags

ee/app/views/projects/mirrors/_push.html.haml

 - expanded = Rails.env.test?
-%section.settings.project-remote-mirror-settings.no-animate{ class: ('expanded' if expanded) }
+%section.settings.no-animate{ class: ('expanded' if expanded) }
   .settings-header
     %h4
       Push to a remote repository

ee/app/views/projects/push_rules/_index.html.haml

 - return unless @project.feature_available?(:push_rules)
 
 - expanded = Rails.env.test?
-%section.settings.repository-push-rules.no-animate{ class: ('expanded' if expanded) }
+%section.settings.no-animate{ class: ('expanded' if expanded) }
   .settings-header
     %h4
       Push Rules

qa/qa/page/project/settings/common.rb

@@ -11,11 +11,16 @@ module QA
             end
           end
 
-          def expand_section(selector)
-            page.within(selector) do
-              find_button('Expand').click
+          # Click the Expand button present in the specified section
+          #
+          # @param [String] name present in the container in the DOM
+          def expand_section(name)
+            page.within('#content-body') do
+              page.within('section', text: name) do
+                click_button('Expand')
 
-              yield if block_given?
+                yield if block_given?
+              end
             end
           end
         end

qa/qa/page/project/settings/main.rb

@@ -6,11 +6,11 @@ module QA
           include Common
 
           view 'app/views/projects/edit.html.haml' do
-            element :advanced_settings_section, '%section.settings.advanced-settings'
+            element :advanced_settings_section, 'Advanced settings'
           end
 
           def expand_advanced_settings(&block)
-            expand_section('section.advanced-settings') do
+            expand_section('Advanced settings') do
               Advanced.perform(&block)
             end
           end

qa/qa/page/project/settings/repository.rb

@@ -6,11 +6,11 @@ module QA
           include Common
 
           view 'app/views/projects/deploy_keys/_index.html.haml' do
-            element :expand_deploy_keys_section, '.repository-deploy-keys'
+            element :deploy_keys_section, 'Deploy Keys'
           end
 
           def expand_deploy_keys(&block)
-            expand_section('section.repository-deploy-keys') do
+            expand_section('Deploy Keys') do
               DeployKeys.perform(&block)
             end
           end