Merge branch 'jivanvl-remove-store_pipeline_messages-ff' into 'master'

Support warning in pipeline creation by default [RUN ALL RSPEC] [RUN AS-IF-FOSS]

See merge request gitlab-org/gitlab!61803

app/models/ci/pipeline.rb

@@ -1255,8 +1255,6 @@ module Ci
     private
 
     def add_message(severity, content)
-      return unless Gitlab::Ci::Features.store_pipeline_messages?(project)
-
       messages.build(severity: severity, content: content)
     end
 

changelogs/unreleased/jivanvl-remove-store_pipeline_messages-ff.yml

+---
+title: Support warning in pipeline creation by default
+merge_request: 61803
+author:
+type: changed

config/feature_flags/development/ci_store_pipeline_messages.yml

----
-name: ci_store_pipeline_messages
-introduced_by_url: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/33762
-rollout_issue_url: https://gitlab.com/gitlab-org/gitlab/-/issues/224199
-milestone: '13.2'
-type: development
-group: group::continuous integration
-default_enabled: true

lib/gitlab/ci/features.rb

@@ -22,11 +22,6 @@ module Gitlab
         Feature.enabled?(:merge_base_pipeline_for_metrics_comparison, project, default_enabled: :yaml)
       end
 
-      # Remove in https://gitlab.com/gitlab-org/gitlab/-/issues/224199
-      def self.store_pipeline_messages?(project)
-        ::Feature.enabled?(:ci_store_pipeline_messages, project, default_enabled: true)
-      end
-
       def self.raise_job_rules_without_workflow_rules_warning?
         ::Feature.enabled?(:ci_raise_job_rules_without_workflow_rules_warning, default_enabled: true)
       end

spec/models/ci/pipeline_spec.rb

@@ -3234,18 +3234,6 @@ RSpec.describe Ci::Pipeline, :mailer, factory_default: :keep do
 
       expect(pipeline.messages.map(&:content)).to contain_exactly('The error message')
     end
-
-    context 'when feature flag ci_store_pipeline_messages is disabled' do
-      before do
-        stub_feature_flags(ci_store_pipeline_messages: false)
-      end
-
-      it 'does not add pipeline error message' do
-        pipeline.add_error_message('The error message')
-
-        expect(pipeline.messages).to be_empty
-      end
-    end
   end
 
   describe '#has_yaml_errors?' do