Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
ce54ba05
Commit
ce54ba05
authored
Dec 02, 2021
by
Siddharth Asthana
Committed by
Peter Leitzen
Apr 08, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Style/OpenStructUse offenses
Changelog: other
parent
c9127868
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
7 deletions
+6
-7
.rubocop_todo/style/open_struct_use.yml
.rubocop_todo/style/open_struct_use.yml
+0
-2
spec/lib/gitlab/legacy_github_import/project_creator_spec.rb
spec/lib/gitlab/legacy_github_import/project_creator_spec.rb
+2
-2
spec/lib/gitlab/quick_actions/command_definition_spec.rb
spec/lib/gitlab/quick_actions/command_definition_spec.rb
+4
-3
No files found.
.rubocop_todo/style/open_struct_use.yml
View file @
ce54ba05
...
...
@@ -18,7 +18,5 @@ Style/OpenStructUse:
-
spec/helpers/profiles_helper_spec.rb
-
spec/lib/gitlab/gitaly_client/blobs_stitcher_spec.rb
-
spec/lib/gitlab/gitaly_client/diff_stitcher_spec.rb
-
spec/lib/gitlab/legacy_github_import/project_creator_spec.rb
-
spec/lib/gitlab/quick_actions/command_definition_spec.rb
-
spec/services/system_note_service_spec.rb
-
spec/support/helpers/repo_helpers.rb
spec/lib/gitlab/legacy_github_import/project_creator_spec.rb
View file @
ce54ba05
...
...
@@ -7,7 +7,7 @@ RSpec.describe Gitlab::LegacyGithubImport::ProjectCreator do
let
(
:namespace
)
{
create
(
:group
)
}
let
(
:repo
)
do
OpenStruct
.
new
(
ActiveSupport
::
InheritableOptions
.
new
(
login:
'vim'
,
name:
'vim'
,
full_name:
'asd/vim'
,
...
...
@@ -21,7 +21,7 @@ RSpec.describe Gitlab::LegacyGithubImport::ProjectCreator do
namespace
.
add_owner
(
user
)
expect_next_instance_of
(
Project
)
do
|
project
|
expect
(
project
).
to
receive
(
:add_import_job
)
allow
(
project
).
to
receive
(
:add_import_job
)
end
end
...
...
spec/lib/gitlab/quick_actions/command_definition_spec.rb
View file @
ce54ba05
...
...
@@ -26,7 +26,7 @@ RSpec.describe Gitlab::QuickActions::CommandDefinition do
describe
"#noop?"
do
context
"when the command has an action block"
do
before
do
subject
.
action_block
=
proc
{
}
subject
.
action_block
=
proc
{}
end
it
"returns false"
do
...
...
@@ -42,7 +42,7 @@ RSpec.describe Gitlab::QuickActions::CommandDefinition do
end
describe
"#available?"
do
let
(
:opts
)
{
OpenStruct
.
new
(
go:
false
)
}
let
(
:opts
)
{
ActiveSupport
::
InheritableOptions
.
new
(
go:
false
)
}
context
"when the command has a condition block"
do
before
do
...
...
@@ -104,7 +104,8 @@ RSpec.describe Gitlab::QuickActions::CommandDefinition do
end
describe
"#execute"
do
let
(
:context
)
{
OpenStruct
.
new
(
run:
false
,
commands_executed_count:
nil
)
}
let
(
:fake_context
)
{
Struct
.
new
(
:run
,
:commands_executed_count
,
:received_arg
)
}
let
(
:context
)
{
fake_context
.
new
(
false
,
nil
,
nil
)
}
context
"when the command is a noop"
do
it
"doesn't execute the command"
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment