Refactor query to loop through epics

ceb0924c · Mark Chao · 03d1f887 · ceb0924c
Commit ceb0924c authored Jul 25, 2018 by Mark Chao
Hide whitespace changes
Inline Side-by-side

Showing with 2 additions and 4 deletions

ee/app/services/ee/milestones/update_service.rb ee/app/services/ee/milestones/update_service.rb +2 -4

No files found.
--- a/ee/app/services/ee/milestones/update_service.rb
+++ b/ee/app/services/ee/milestones/update_service.rb
@@ -7,10 +7,8 @@ module EE
      def execute(milestone)
        super
-        milestone.issues.includes(epic: :group).each do |issue|
+        ::Epic.joins(:issues).where(issues: { milestone_id: milestone.id }).each do |epic|
-          if issue.epic
+          epic.update_dates
-            issue.epic.update_dates
-          end
        end
        milestone