Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
cf353bd3
Commit
cf353bd3
authored
Jan 15, 2013
by
Dmitriy Zaporozhets
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed spinach test
parent
752eb2c1
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
10 deletions
+13
-10
features/project/commits/commit_diff_comments.feature
features/project/commits/commit_diff_comments.feature
+6
-5
features/steps/project/project_merge_requests.rb
features/steps/project/project_merge_requests.rb
+7
-5
No files found.
features/project/commits/commit_diff_comments.feature
View file @
cf353bd3
...
...
@@ -84,8 +84,9 @@ Feature: Comments on commit diffs
Then
I should not see the diff comment form
And
I should see a discussion reply button
@javascript
Scenario
:
I
can delete a discussion comment
Given
I leave a diff comment like
"Typo, please fix"
And
I delete a diff comment
Then
I should not see a diff comment saying
"Typo, please fix"
#@wip @javascript
#Scenario: I can delete a discussion comment
# Given I leave a diff comment like "Typo, please fix"
# And I delete a diff comment
# Then I should not see a diff comment saying "Typo, please fix"
features/steps/project/project_merge_requests.rb
View file @
cf353bd3
...
...
@@ -103,6 +103,8 @@ class ProjectMergeRequests < Spinach::FeatureSteps
end
And
'I leave a comment on the diff page'
do
find
(
"#4735dfc552ad7bf15ca468adc3cad9d05b624490_185_185 .add-diff-note"
).
click
within
(
'.js-temp-notes-holder'
)
do
fill_in
"note_note"
,
with:
"One comment to rule them all"
click_button
"Add Comment"
...
...
@@ -122,7 +124,7 @@ class ProjectMergeRequests < Spinach::FeatureSteps
Then
'I should see a discussion has started on line 185'
do
mr
=
MergeRequest
.
find_by_title
(
"Bug NS-05"
)
first_commit
=
mr
.
commits
.
first
first_diff
=
mr
.
diffs
.
first
first_diff
=
first_commit
.
diffs
.
first
page
.
should
have_content
"
#{
current_user
.
name
}
started a discussion on this merge request diff"
page
.
should
have_content
"
#{
first_diff
.
b_path
}
:L185"
page
.
should
have_content
"Line is wrong"
...
...
@@ -131,7 +133,7 @@ class ProjectMergeRequests < Spinach::FeatureSteps
Then
'I should see a discussion has started on commit bcf03b5de6c:L185'
do
mr
=
MergeRequest
.
find_by_title
(
"Bug NS-05"
)
first_commit
=
mr
.
commits
.
first
first_diff
=
mr
.
diffs
.
first
first_diff
=
first_commit
.
diffs
.
first
page
.
should
have_content
"
#{
current_user
.
name
}
started a discussion on commit"
page
.
should
have_content
first_commit
.
short_id
(
8
)
page
.
should
have_content
"
#{
first_diff
.
b_path
}
:L185"
...
...
@@ -141,10 +143,10 @@ class ProjectMergeRequests < Spinach::FeatureSteps
Then
'I should see a discussion has started on commit bcf03b5de6c'
do
mr
=
MergeRequest
.
find_by_title
(
"Bug NS-05"
)
first_commit
=
mr
.
st_commits
.
first
first_diff
=
mr
.
diffs
.
first
page
.
should
have_content
"
#{
current_user
.
name
}
started a discussion on commit"
first_diff
=
first_commit
.
diffs
.
first
page
.
should
have_content
"
#{
current_user
.
name
}
started a discussion on commit
bcf03b5de6c
"
page
.
should
have_content
first_commit
.
short_id
(
8
)
page
.
should
have_content
"One comment to rule them all"
page
.
should
_not
have_content
"
#{
first_diff
.
b_path
}
:L185"
page
.
should
have_content
"
#{
first_diff
.
b_path
}
:L185"
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment