Eliminate @response instance variable

d1c5f97a · Alex Kalderimis · 939d3d48 · d1c5f97a
Commit d1c5f97a authored Jan 08, 2020 by Alex Kalderimis
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 3 deletions

app/models/project_services/external_wiki_service.rb app/models/project_services/external_wiki_service.rb +4 -3

No files found.
--- a/app/models/project_services/external_wiki_service.rb
+++ b/app/models/project_services/external_wiki_service.rb
@@ -29,9 +29,10 @@ class ExternalWikiService < Service
  end

  def execute(_data)
-    @response = Gitlab::HTTP.get(properties['external_wiki_url'], verify: true) rescue nil
-
-    @response.body if @response.code == 200
+    response = Gitlab::HTTP.get(properties['external_wiki_url'], verify: true)
+    response.body if response.code == 200
+  rescue
+    nil
  end

  def self.supported_events