Commit d4066b09 authored by Heinrich Lee Yu's avatar Heinrich Lee Yu

Merge branch 'comment_project_wildcard_conflict' into 'master'

Note about route conflicts linking to guidelines

See merge request gitlab-org/gitlab!29455
parents 51d2127a e6e9c13f
...@@ -57,6 +57,10 @@ module Gitlab ...@@ -57,6 +57,10 @@ module Gitlab
v2 v2
].freeze ].freeze
# NOTE: Do not add new items to this list unless necessary as this will
# cause conflicts with existing namespaced routes for groups or projects.
# See https://docs.gitlab.com/ee/development/routing.html#project-routes
#
# This list should contain all words following `/*namespace_id/:project_id` in # This list should contain all words following `/*namespace_id/:project_id` in
# routes that contain a second wildcard. # routes that contain a second wildcard.
# #
...@@ -103,6 +107,10 @@ module Gitlab ...@@ -103,6 +107,10 @@ module Gitlab
wikis wikis
].freeze ].freeze
# NOTE: Do not add new items to this list unless necessary as this will
# cause conflicts with existing namespaced routes for groups or projects.
# See https://docs.gitlab.com/ee/development/routing.html#group-routes
#
# These are all the paths that follow `/groups/*id/ or `/groups/*group_id` # These are all the paths that follow `/groups/*id/ or `/groups/*group_id`
# We need to reject these because we have a `/groups/*id` page that is the same # We need to reject these because we have a `/groups/*id` page that is the same
# as the `/*id`. # as the `/*id`.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment