Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d4c88dca
Commit
d4c88dca
authored
Nov 21, 2019
by
Dheeraj Joshi
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use correct fragment identifier for vulnerability help path
parent
f4ffffff
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
2 deletions
+11
-2
changelogs/unreleased/35616-broken-anchor-for-learn-more-about-interacting-with-security-report.yml
...for-learn-more-about-interacting-with-security-report.yml
+5
-0
ee/app/assets/javascripts/vue_shared/security_reports/components/solution_card.vue
.../vue_shared/security_reports/components/solution_card.vue
+5
-1
ee/spec/frontend/vue_shared/security_reports/components/modal_spec.js
...tend/vue_shared/security_reports/components/modal_spec.js
+1
-1
No files found.
changelogs/unreleased/35616-broken-anchor-for-learn-more-about-interacting-with-security-report.yml
0 → 100644
View file @
d4c88dca
---
title
:
Use correct fragment identifier for vulnerability help path
merge_request
:
20524
author
:
type
:
fixed
ee/app/assets/javascripts/vue_shared/security_reports/components/solution_card.vue
View file @
d4c88dca
<
script
>
import
{
GlButton
}
from
'
@gitlab/ui
'
;
import
Icon
from
'
~/vue_shared/components/icon.vue
'
;
import
{
setUrlFragment
}
from
'
~/lib/utils/url_utility
'
;
export
default
{
name
:
'
SolutionCard
'
,
...
...
@@ -42,7 +43,10 @@ export default {
return
(
this
.
remediation
&&
this
.
remediation
.
summary
)
||
this
.
solution
;
},
helpPath
()
{
return
`
${
this
.
vulnerabilityFeedbackHelpPath
}
#solutions-for-vulnerabilities`
;
return
setUrlFragment
(
this
.
vulnerabilityFeedbackHelpPath
,
'
solutions-for-vulnerabilities-auto-remediation
'
,
);
},
showCreateMergeRequestMsg
()
{
return
!
this
.
hasMr
&&
this
.
hasRemediation
&&
this
.
hasDownload
;
...
...
ee/spec/frontend/vue_shared/security_reports/components/modal_spec.js
View file @
d4c88dca
...
...
@@ -109,7 +109,7 @@ describe('Security Reports modal', () => {
it
(
'
renders help link
'
,
()
=>
{
expect
(
wrapper
.
find
(
'
.js-link-vulnerabilityFeedbackHelpPath
'
).
attributes
(
'
href
'
)).
toBe
(
'
feedbacksHelpPath#solutions-for-vulnerabilities
'
,
'
feedbacksHelpPath#solutions-for-vulnerabilities
-auto-remediation
'
,
);
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment