Merge branch '198610-remove-ace' into 'master'

Removed ACE editor from the codebase

See merge request gitlab-org/gitlab!46420

Gemfile

@@ -272,9 +272,6 @@ gem 'loofah', '~> 2.2'
 # Working with license
 gem 'licensee', '~> 8.9'
 
-# Ace editor
-gem 'ace-rails-ap', '~> 4.1.0'
-
 # Detect and convert string character encoding
 gem 'charlock_holmes', '~> 0.7.7'
 

Gemfile.lock

@@ -3,7 +3,6 @@ GEM
   specs:
     RedCloth (4.3.2)
     abstract_type (0.0.7)
-    ace-rails-ap (4.1.2)
     acme-client (2.0.6)
       faraday (>= 0.17, < 2.0.0)
     actioncable (6.0.3.3)
@@ -1253,7 +1252,6 @@ PLATFORMS
 
 DEPENDENCIES
   RedCloth (~> 4.3.2)
-  ace-rails-ap (~> 4.1.0)
   acme-client (~> 2.0, >= 2.0.6)
   activerecord-explain-analyze (~> 0.1)
   acts-as-taggable-on (~> 6.0)

app/assets/javascripts/lib/ace.js

-/*= require ace/ace */
-/*= require ace/ext-modelist */
-/*= require ace/ext-searchbox */
-/*= require ./ace/ace_config_paths */

app/assets/javascripts/lib/ace/ace_config_paths.js.erb

-<%
-ace_gem_path = Bundler.rubygems.find_name('ace-rails-ap').first.full_gem_path
-ace_workers = Dir[ace_gem_path + '/vendor/assets/javascripts/ace/worker-*.js'].sort.map do |file|
-  File.basename(file, '.js').sub(/^worker-/, '')
-end
-ace_modes = Dir[ace_gem_path + '/vendor/assets/javascripts/ace/mode-*.js'].sort.map do |file|
-  File.basename(file, '.js').sub(/^mode-/, '')
-end
-%>
-// Lazy-load configuration when ace.edit is called
-(function() {
-  var basePath;
-  var ace = window.ace;
-  var edit = ace.edit;
-  ace.edit = function() {
-    window.gon = window.gon || {};
-    basePath = (window.gon.relative_url_root || '').replace(/\/$/, '') + '/assets/ace';
-    ace.config.set('basePath', basePath);
-
-    // configure paths for all worker modules
-<% ace_workers.each do |worker| %>
-    ace.config.setModuleUrl('ace/mode/<%= worker %>_worker', basePath + '/<%= File.basename(asset_path("ace/worker-#{worker}.js")) %>');
-<% end %>
-
-    // configure paths for all mode modules
-<% ace_modes.each do |mode| %>
-    ace.config.setModuleUrl('ace/mode/<%= mode %>', basePath + '/<%= File.basename(asset_path("ace/mode-#{mode}.js")) %>');
-<% end %>
-
-    // restore original method
-    ace.edit = edit;
-    return ace.edit.apply(ace, arguments);
-  };
-})();

app/assets/javascripts/lib/utils/ace_utils.js

-/* global ace */
-
-export default function getModeByFileExtension(path) {
-  const modelist = ace.require('ace/ext/modelist');
-  return modelist.getModeForPath(path).mode;
-}

app/views/projects/merge_requests/conflicts/show.html.haml

 - page_title _("Merge Conflicts"), "#{@merge_request.title} (#{@merge_request.to_reference}", _("Merge Requests")
 - add_page_specific_style 'page_bundles/merge_conflicts'
-- content_for :page_specific_javascripts do
-  = page_specific_javascript_tag('lib/ace.js')
 = render "projects/merge_requests/mr_title"
 
 .merge-request-details.issuable-details

changelogs/unreleased/198610-remove-ace.yml

+---
+title: Removed ACE editor from the codebase
+merge_request: 46420
+author:
+type: removed

config/application.rb

@@ -201,7 +201,6 @@ module Gitlab
     config.assets.precompile << "page_bundles/xterm.css"
     config.assets.precompile << "lazy_bundles/cropper.css"
     config.assets.precompile << "performance_bar.css"
-    config.assets.precompile << "lib/ace.js"
     config.assets.precompile << "disable_animations.css"
     config.assets.precompile << "snippets.css"
     config.assets.precompile << "locale/**/app.js"