Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
d76a6bb7
Commit
d76a6bb7
authored
May 10, 2021
by
Jan Provaznik
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove limit_epic_groups_query flag
parent
877dc25a
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
7 additions
and
22 deletions
+7
-22
config/feature_flags/development/limit_epic_groups_query.yml
config/feature_flags/development/limit_epic_groups_query.yml
+0
-8
ee/app/finders/epics_finder.rb
ee/app/finders/epics_finder.rb
+2
-4
ee/changelogs/unreleased/ff-epic-finder.yml
ee/changelogs/unreleased/ff-epic-finder.yml
+5
-0
ee/spec/finders/epics_finder_spec.rb
ee/spec/finders/epics_finder_spec.rb
+0
-10
No files found.
config/feature_flags/development/limit_epic_groups_query.yml
deleted
100644 → 0
View file @
877dc25a
---
name
:
limit_epic_groups_query
introduced_by_url
:
https://gitlab.com/gitlab-org/gitlab/-/merge_requests/59360
rollout_issue_url
:
https://gitlab.com/gitlab-org/gitlab/-/issues/327624
milestone
:
'
13.12'
type
:
development
group
:
group::product planning
default_enabled
:
false
ee/app/finders/epics_finder.rb
View file @
d76a6bb7
...
...
@@ -102,10 +102,8 @@ class EpicsFinder < IssuableFinder
# all epics in all subgroups
next
groups
if
can_read_all_epics_in_related_groups?
(
groups
,
include_confidential:
false
)
if
Feature
.
enabled?
(
:limit_epic_groups_query
,
group
)
next
groups
.
public_to_user
unless
current_user
next
groups
.
public_to_user
(
current_user
)
unless
groups
.
user_is_member
(
current_user
).
exists?
end
next
groups
.
public_to_user
unless
current_user
next
groups
.
public_to_user
(
current_user
)
unless
groups
.
user_is_member
(
current_user
).
exists?
# when traversal ids are enabled, we could avoid N+1 issue
# by taking all public groups plus groups where user is member
...
...
ee/changelogs/unreleased/ff-epic-finder.yml
0 → 100644
View file @
d76a6bb7
---
title
:
Optimize number of SQL queries when listing epics.
merge_request
:
61372
author
:
type
:
performance
ee/spec/finders/epics_finder_spec.rb
View file @
d76a6bb7
...
...
@@ -570,16 +570,6 @@ RSpec.describe EpicsFinder do
end
it_behaves_like
'avoids N+1 queries'
context
'when limit_epic_groups_query is disabled'
do
before
do
stub_feature_flags
(
limit_epic_groups_query:
false
)
end
it
'returns only public epics'
do
expect
(
execute
).
to
match_array
([
base_epic2
,
public_epic1
,
internal_epic
])
end
end
end
context
'when skip_visibility_check is true'
do
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment