Improve background retry tests

spec/controllers/projects/pipelines_controller_spec.rb

@@ -853,6 +853,15 @@ RSpec.describe Projects::PipelinesController do
   end
 
   describe 'POST retry.json' do
+    subject(:post_retry) do
+      post :retry, params: {
+                     namespace_id: project.namespace,
+                     project_id: project,
+                     id: pipeline.id
+                   },
+                   format: :json
+    end
+
     let!(:pipeline) { create(:ci_pipeline, :failed, project: project) }
     let!(:build) { create(:ci_build, :failed, pipeline: pipeline) }
 
@@ -860,24 +869,34 @@ RSpec.describe Projects::PipelinesController do
 
     before do
       stub_const('::Ci::RetryPipelineWorker', worker_spy)
-
-      post :retry, params: {
-                     namespace_id: project.namespace,
-                     project_id: project,
-                     id: pipeline.id
-                   },
-                   format: :json
     end
 
     it 'retries a pipeline in the background without returning any content' do
+      post_retry
+
       expect(response).to have_gitlab_http_status(:no_content)
       expect(::Ci::RetryPipelineWorker).to have_received(:perform_async).with(pipeline.id, user.id)
     end
 
+    context 'when feature flag is disabled' do
+      before do
+        stub_feature_flags(background_pipeline_retry_endpoint: false)
+      end
+
+      it 'retries the pipeline without returning any content' do
+        post_retry
+
+        expect(response).to have_gitlab_http_status(:no_content)
+        expect(build.reload).to be_retried
+      end
+    end
+
     context 'when builds are disabled' do
       let(:feature) { ProjectFeature::DISABLED }
 
       it 'fails to retry pipeline' do
+        post_retry
+
         expect(response).to have_gitlab_http_status(:not_found)
       end
     end

spec/workers/ci/retry_pipeline_worker_spec.rb

@@ -43,8 +43,8 @@ RSpec.describe Ci::RetryPipelineWorker do
       let(:pipeline_id) { 1234 }
       let(:user_id) { 1234 }
 
-      it 'returns false' do
-        expect(perform).to eq(nil)
+      it 'returns nil' do
+        expect(perform).to be_nil
       end
     end
   end