Merge branch 'redundant-sort-cop' into 'master'

Fix Style/RedundantSort cop

See merge request gitlab-org/gitlab!41108

.rubocop_todo.yml

@@ -638,13 +638,6 @@ Style/RedundantInterpolation:
 Style/RedundantSelf:
   Enabled: false
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/RedundantSort:
-  Exclude:
-    - 'app/presenters/packages/nuget/search_results_presenter.rb'
-    - 'spec/presenters/packages/nuget/search_results_presenter_spec.rb'
-
 # Offense count: 120
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, AllowInnerSlashes.

app/presenters/packages/nuget/search_results_presenter.rb

@@ -49,7 +49,7 @@ module Packages
 
       def latest_version(packages)
         versions = packages.map(&:version).compact
-        VersionSorter.sort(versions).last # rubocop: disable Style/UnneededSort
+        VersionSorter.sort(versions).last # rubocop: disable Style/RedundantSort
       end
     end
   end

changelogs/unreleased/redundant-sort-cop.yml

+---
+title: Fix Style/RedundantSort cop
+merge_request: 41108
+author: Rajendra Kadam
+type: fixed

spec/presenters/packages/nuget/search_results_presenter_spec.rb

@@ -37,7 +37,7 @@ RSpec.describe Packages::Nuget::SearchResultsPresenter do
       expect(package_json[:summary]).to be_blank
       expect(package_json[:total_downloads]).to eq 0
       expect(package_json[:verified]).to be
-      expect(package_json[:version]).to eq VersionSorter.sort(versions).last # rubocop: disable Style/UnneededSort
+      expect(package_json[:version]).to eq VersionSorter.sort(versions).last # rubocop: disable Style/RedundantSort
       versions.zip(package_json[:versions]).each do |version, version_json|
         expect(version_json[:json_url]).to end_with("#{version}.json")
         expect(version_json[:downloads]).to eq 0