Added tests

Updated docs

app/services/slash_commands/interpret_service.rb

@@ -319,13 +319,12 @@ module SlashCommands
     desc 'Set weight'
     params '1-9'
     condition do
-      issuable.persisted? &&
-        issuable.is_a?(Issue) &&
+      issuable.is_a?(Issue) &&
         current_user.can?(:"update_#{issuable.to_ability_name}", issuable)
     end
     command :weight do |weight|
       if Issue.weight_filter_options.include?(weight.to_i)
-        @updates[:weight] = weight
+        @updates[:weight] = weight.to_i
       end
     end
 

doc/user/project/slash_commands.md

@@ -35,3 +35,5 @@ do.
 | <code>/spend &lt;1h 30m &#124; -1h 5m&gt;</code> | Add or subtract spent time |
 | `/remove_time_spent`       | Remove time spent |
 | `/target_branch <Branch Name>` | Set target branch for current merge request |
+| `/weight <1-9>` | Set the weight of the issue |
+| `/clear_weight` | Clears the issue weight |

spec/features/issues/user_uses_slash_commands_spec.rb

@@ -161,5 +161,81 @@ feature 'Issues > User uses slash commands', feature: true, js: true do
         expect(page).not_to have_content '/wip'
       end
     end
+
+    describe 'adding a weight from a note' do
+      let(:issue) { create(:issue, project: project) }
+
+      context 'when the user can update the weight' do
+        it 'does not create a note, and sets the weight accordingly' do
+          write_note("/weight 5")
+
+          expect(page).not_to have_content '/weight 5'
+          expect(page).to have_content 'Commands applied'
+
+          issue.reload
+
+          expect(issue.weight).to eq(5)
+        end
+      end
+
+      context 'when the current user cannot update the weight' do
+        let(:guest) { create(:user) }
+        before do
+          project.team << [guest, :guest]
+          logout
+          login_with(guest)
+          visit namespace_project_issue_path(project.namespace, project, issue)
+        end
+
+        it 'creates a note, and does not set the weight' do
+          write_note("/weight 5")
+
+          expect(page).to have_content '/weight 5'
+          expect(page).not_to have_content 'Commands applied'
+
+          issue.reload
+
+          expect(issue.weight).not_to eq(5)
+        end
+      end
+    end
+
+    describe 'removing weight from a note' do
+      let(:issue) { create(:issue, project: project, weight: 1) }
+
+      context 'when the user can update the weight' do
+        it 'does not create a note, and removes the weight accordingly' do
+          write_note("/clear_weight")
+
+          expect(page).not_to have_content '/clear_weight'
+          expect(page).to have_content 'Commands applied'
+
+          issue.reload
+
+          expect(issue.weight).to eq(nil)
+        end
+      end
+
+      context 'when the current user cannot update the weight' do
+        let(:guest) { create(:user) }
+        before do
+          project.team << [guest, :guest]
+          logout
+          login_with(guest)
+          visit namespace_project_issue_path(project.namespace, project, issue)
+        end
+
+        it 'creates a note, and does not set the weight' do
+          write_note("/clear_weight")
+
+          expect(page).to have_content '/clear_weight'
+          expect(page).not_to have_content 'Commands applied'
+
+          issue.reload
+
+          expect(issue.weight).to eq(1)
+        end
+      end
+    end
   end
 end

spec/features/merge_requests/user_uses_slash_commands_spec.rb

@@ -196,5 +196,13 @@ feature 'Merge Requests > User uses slash commands', feature: true, js: true do
         end
       end
     end
+
+    describe 'adding a weight from a note' do
+      it 'does not recognize the command nor create a note' do
+        write_note("/weight 5")
+
+        expect(page).not_to have_content '/weight 5'
+      end
+    end
   end
 end

spec/services/slash_commands/interpret_service_spec.rb

@@ -267,6 +267,23 @@ describe SlashCommands::InterpretService, services: true do
       end
     end
 
+    shared_examples 'weight command' do
+      it 'populates weight: 5 if content contains /weight 5' do
+        _, updates = service.execute(content, issuable)
+
+        expect(updates).to eq(weight: 5)
+      end
+    end
+
+    shared_examples 'clear weight command' do
+      it 'populates weight: nil if content contains /clear_weight' do
+        issuable.update(weight: 5)
+        _, updates = service.execute(content, issuable)
+
+        expect(updates).to eq(weight: nil)
+      end
+    end
+
     it_behaves_like 'reopen command' do
       let(:content) { '/reopen' }
       let(:issuable) { issue }
@@ -603,6 +620,16 @@ describe SlashCommands::InterpretService, services: true do
       let(:issuable) { issue }
     end
 
+    it_behaves_like 'weight command' do
+      let(:content) { '/weight 5'}
+      let(:issuable) { issue }
+    end
+
+    it_behaves_like 'clear weight command' do
+      let(:content) { '/clear_weight' }
+      let(:issuable) { issue }
+    end
+
     context 'when current_user cannot :admin_issue' do
       let(:visitor) { create(:user) }
       let(:issue) { create(:issue, project: project, author: visitor) }