Simplifies HTML & CSS after code review

app/assets/stylesheets/pages/merge_requests.scss

@@ -803,25 +803,16 @@
         }
       }
 
-
-      li.success {
-        .mr-widget-code-quality-title {
-          color: $green-500;
-        }
-
-        .mr-widget-code-quality-icon svg {
-          fill: $green-500;
-        }
+      .mr-widget-code-quality-icon {
+        fill: currentColor;
       }
 
-      li.failed {
-        .mr-widget-code-quality-title {
-          color: $red-500;
-        }
+      .success {
+        color: $green-500;
+      }
 
-        .mr-widget-code-quality-icon svg {
-          fill: $red-500;
-        }
+      .failed {
+        color: $red-500;
       }
     }
   }

ee/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_code_quality.vue

@@ -132,10 +132,7 @@ export default {
       v-if="isLoading"
       class="media">
       <div class="mr-widget-icon">
-        <i
-          class="fa fa-spinner fa-spin"
-          aria-hidden="true">
-        </i>
+        <loading-icon />
       </div>
       <div class="media-body">
         Loading codeclimate report

ee/app/assets/javascripts/vue_merge_request_widget/components/mr_widget_code_quality_issues.vue

@@ -14,11 +14,8 @@
       },
     },
     computed: {
-      plusIcon() {
-        return spriteIcon('plus');
-      },
-      minusIcon() {
-        return spriteIcon('cut');
+      icon() {
+        return this.isTypeFailed ? spriteIcon('cut') : spriteIcon('plus');
       },
       isTypeFailed() {
         return this.type === 'failed';
@@ -39,22 +36,10 @@
       "v-for="issue in issues">
       <span
         class="mr-widget-code-quality-icon"
-        v-if="isTypeFailed"
-        v-html="minusIcon">
-      </span>
-      <span
-        class="mr-widget-code-quality-icon"
-        v-else-if="isTypeSuccess"
-        v-html="plusIcon">
-      </span>
-      <span
-        class="mr-widget-code-quality-title"
-        v-if="isTypeSuccess">
-        Fixed:
-      </span>
-      <span class="mr-widget-code-quality-title">
-        {{issue.check_name}}
+        v-html="icon">
       </span>
+      <template v-if="isTypeSuccess">Fixed:</template>
+      {{issue.check_name}}
       <template v-if="issue.location.path">in</template>
       <a
         :href="issue.location.urlPath"