Merge branch 'pl-rubocop-rspec-leaky-constant-declaration-exclusions' into 'master'

Move exclusions for RSpec/LeakyConstantDeclaration to .rubocop_todo

See merge request gitlab-org/gitlab!79356

.rubocop.yml

@@ -517,24 +517,6 @@ Graphql/Descriptions:
 RSpec/ImplicitSubject:
   Enabled: false
 
-# WIP See https://gitlab.com/gitlab-org/gitlab/-/issues/211580
-RSpec/LeakyConstantDeclaration:
-  Enabled: true
-  Exclude:
-    - 'spec/db/schema_spec.rb'
-    - 'spec/lib/feature_spec.rb'
-    - 'spec/lib/gitlab/config/entry/simplifiable_spec.rb'
-    - 'spec/lib/gitlab/quick_actions/dsl_spec.rb'
-    - 'spec/lib/marginalia_spec.rb'
-    - 'spec/mailers/notify_spec.rb'
-    - 'spec/models/concerns/batch_destroy_dependent_associations_spec.rb'
-    - 'spec/models/concerns/bulk_insert_safe_spec.rb'
-    - 'spec/models/concerns/bulk_insertable_associations_spec.rb'
-    - 'spec/models/concerns/triggerable_hooks_spec.rb'
-    - 'spec/models/repository_spec.rb'
-    - 'spec/services/clusters/applications/check_installation_progress_service_spec.rb'
-    - 'spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb'
-
 RSpec/EmptyLineAfterHook:
   Enabled: false
 

.rubocop_todo/rspec/leaky_constant_declaration.yml

+---
+RSpec/LeakyConstantDeclaration:
+  Exclude:
+  - spec/db/schema_spec.rb
+  - spec/lib/gitlab/config/entry/simplifiable_spec.rb
+  - spec/lib/gitlab/quick_actions/dsl_spec.rb
+  - spec/lib/marginalia_spec.rb
+  - spec/mailers/notify_spec.rb
+  - spec/models/concerns/batch_destroy_dependent_associations_spec.rb
+  - spec/models/concerns/bulk_insert_safe_spec.rb
+  - spec/models/concerns/bulk_insertable_associations_spec.rb
+  - spec/models/concerns/triggerable_hooks_spec.rb
+  - spec/models/repository_spec.rb
+  - spec/services/clusters/applications/check_installation_progress_service_spec.rb
+  - spec/support/shared_examples/quick_actions/issuable/issuable_quick_actions_shared_examples.rb