Merge branch '217680-health-metric-instrumentation' into 'master'

Track Sentry error status updates with dedicated actions

See merge request gitlab-org/gitlab!33623

app/assets/javascripts/error_tracking/components/error_details.vue

@@ -233,8 +233,8 @@ export default {
       Tracking.event(category, action);
     },
     trackStatusUpdate(status) {
-      const { category, action, label } = trackErrorStatusUpdateOptions;
-      Tracking.event(category, action, { label, property: status });
+      const { category, action } = trackErrorStatusUpdateOptions(status);
+      Tracking.event(category, action);
     },
   },
 };

app/assets/javascripts/error_tracking/components/error_tracking_list.vue

@@ -218,8 +218,8 @@ export default {
       Tracking.event(category, action);
     },
     trackStatusUpdate(status) {
-      const { category, action, label } = trackErrorStatusUpdateOptions;
-      Tracking.event(category, action, { label, property: status });
+      const { category, action } = trackErrorStatusUpdateOptions(status);
+      Tracking.event(category, action);
     },
   },
 };

app/assets/javascripts/error_tracking/utils.js

@@ -30,8 +30,7 @@ export const trackErrorDetailsViewsOptions = {
 /**
  * Tracks snowplow event when error status is updated
  */
-export const trackErrorStatusUpdateOptions = {
+export const trackErrorStatusUpdateOptions = status => ({
   category: 'Error Tracking',
-  action: 'update_error_status',
-  label: 'Status',
-};
+  action: `update_${status}_status`,
+});

changelogs/unreleased/217680-health-metric-instrumentation.yml

+---
+title: Track Sentry error status updates with dedicated actions
+merge_request: 33623
+author:
+type: changed

spec/frontend/error_tracking/components/error_details_spec.js

@@ -519,11 +519,8 @@ describe('ErrorDetails', () => {
       Tracking.event.mockClear();
       findUpdateIgnoreStatusButton().vm.$emit('click');
       setImmediate(() => {
-        const { category, action, label } = trackErrorStatusUpdateOptions;
-        expect(Tracking.event).toHaveBeenCalledWith(category, action, {
-          label,
-          property: 'ignored',
-        });
+        const { category, action } = trackErrorStatusUpdateOptions('ignored');
+        expect(Tracking.event).toHaveBeenCalledWith(category, action);
       });
     });
 
@@ -531,11 +528,8 @@ describe('ErrorDetails', () => {
       Tracking.event.mockClear();
       findUpdateResolveStatusButton().vm.$emit('click');
       setImmediate(() => {
-        const { category, action, label } = trackErrorStatusUpdateOptions;
-        expect(Tracking.event).toHaveBeenCalledWith(category, action, {
-          label,
-          property: 'resolved',
-        });
+        const { category, action } = trackErrorStatusUpdateOptions('resolved');
+        expect(Tracking.event).toHaveBeenCalledWith(category, action);
       });
     });
 

spec/frontend/error_tracking/components/error_tracking_list_spec.js

@@ -491,11 +491,8 @@ describe('ErrorTrackingList', () => {
       });
 
       setImmediate(() => {
-        const { category, action, label } = trackErrorStatusUpdateOptions;
-        expect(Tracking.event).toHaveBeenCalledWith(category, action, {
-          label,
-          property: status,
-        });
+        const { category, action } = trackErrorStatusUpdateOptions(status);
+        expect(Tracking.event).toHaveBeenCalledWith(category, action);
       });
     });
   });