Merge branch '64403-remove-setimmediate-polyfill' into 'master'

Remove setImmediate polyfill from production assets

See merge request gitlab-org/gitlab-ce!30591

config/webpack.config.js

@@ -344,6 +344,8 @@ module.exports = {
 
   devtool: NO_SOURCEMAPS ? false : devtool,
 
-  // sqljs requires fs
-  node: { fs: 'empty' },
+  node: {
+    fs: 'empty', // sqljs requires fs
+    setImmediate: false,
+  },
 };

spec/javascripts/helpers/vuex_action_helper.js

@@ -89,9 +89,7 @@ export default (
     payload,
   );
 
-  return new Promise(resolve => {
-    setImmediate(resolve);
-  })
+  return new Promise(setImmediate)
     .then(() => result)
     .catch(error => {
       validateResults();

spec/javascripts/test_bundle.js

@@ -3,6 +3,7 @@
 */
 
 import $ from 'jquery';
+import 'core-js/features/set-immediate';
 import 'vendor/jasmine-jquery';
 import '~/commons';
 import Vue from 'vue';