Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
1
Merge Requests
1
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
gitlab-ce
Commits
e1e45517
Commit
e1e45517
authored
Mar 30, 2021
by
Abdul Wadood
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix Rails/SaveBang offenses in spec/graphql
Contributes to
https://gitlab.com/gitlab-org/gitlab/-/issues/220040
.
parent
5401b3e8
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
3 additions
and
6 deletions
+3
-6
.rubocop_manual_todo.yml
.rubocop_manual_todo.yml
+0
-3
spec/graphql/mutations/merge_requests/set_locked_spec.rb
spec/graphql/mutations/merge_requests/set_locked_spec.rb
+1
-1
spec/graphql/mutations/merge_requests/set_wip_spec.rb
spec/graphql/mutations/merge_requests/set_wip_spec.rb
+1
-1
spec/graphql/resolvers/boards_resolver_spec.rb
spec/graphql/resolvers/boards_resolver_spec.rb
+1
-1
No files found.
.rubocop_manual_todo.yml
View file @
e1e45517
...
...
@@ -159,9 +159,6 @@ Rails/SaveBang:
-
'
spec/factories_spec.rb'
-
'
spec/frontend/fixtures/issues.rb'
-
'
spec/frontend/fixtures/merge_requests.rb'
-
'
spec/graphql/mutations/merge_requests/set_locked_spec.rb'
-
'
spec/graphql/mutations/merge_requests/set_wip_spec.rb'
-
'
spec/graphql/resolvers/boards_resolver_spec.rb'
-
'
spec/lib/after_commit_queue_spec.rb'
-
'
spec/lib/backup/manager_spec.rb'
-
'
spec/lib/gitlab/alerting/alert_spec.rb'
...
...
spec/graphql/mutations/merge_requests/set_locked_spec.rb
View file @
e1e45517
...
...
@@ -41,7 +41,7 @@ RSpec.describe Mutations::MergeRequests::SetLocked do
let
(
:locked
)
{
false
}
it
'unlocks the discussion'
do
merge_request
.
update
(
discussion_locked:
true
)
merge_request
.
update
!
(
discussion_locked:
true
)
expect
(
mutated_merge_request
).
not_to
be_discussion_locked
end
...
...
spec/graphql/mutations/merge_requests/set_wip_spec.rb
View file @
e1e45517
...
...
@@ -41,7 +41,7 @@ RSpec.describe Mutations::MergeRequests::SetWip do
let
(
:wip
)
{
false
}
it
'removes `wip` from the title'
do
merge_request
.
update
(
title:
"WIP: working on it"
)
merge_request
.
update
!
(
title:
"WIP: working on it"
)
expect
(
mutated_merge_request
).
not_to
be_work_in_progress
end
...
...
spec/graphql/resolvers/boards_resolver_spec.rb
View file @
e1e45517
...
...
@@ -54,7 +54,7 @@ RSpec.describe Resolvers::BoardsResolver do
end
it
'returns nil if board not found'
do
outside_parent
=
create
(
board_parent
.
class
.
underscore
.
to_sym
)
outside_parent
=
create
!
(
board_parent
.
class
.
underscore
.
to_sym
)
outside_board
=
create
(
:board
,
name:
'outside board'
,
resource_parent:
outside_parent
)
expect
(
resolve_boards
(
args:
{
id:
global_id_of
(
outside_board
)
})).
to
eq
Board
.
none
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment