Propagate storage errors

We will handle them in the worker and schedule a retry

ee/app/services/status_page/publish_base_service.rb

@@ -51,8 +51,6 @@ module StatusPage
       storage_client.upload_object(key, content)
 
       success(object_key: key)
-    rescue StatusPage::Storage::Error => e
-      error(e.message, error: e)
     end
 
     def limit_exceeded?(json)

ee/spec/services/status_page/publish_incident_service_spec.rb

@@ -26,14 +26,10 @@ describe StatusPage::PublishIncidentService do
     end
 
     context 'when uploading details fails' do
-      it 'returns error and skip list upload' do
+      it 'propagates the exception' do
         expect_to_upload_details(issue, status: 404)
 
-        expect(result).to be_error
-
-        path = StatusPage::Storage.details_path(issue.iid)
-        expect(result.message).to include('NotFound')
-        expect(result.message).to include(path)
+        expect { result }.to raise_error(StatusPage::Storage::Error)
       end
     end
 
@@ -42,11 +38,7 @@ describe StatusPage::PublishIncidentService do
         expect_to_upload_details(issue)
         expect_to_upload_list(status: 404)
 
-        expect(result).to be_error
-
-        path = StatusPage::Storage.list_path
-        expect(result.message).to include('NotFound')
-        expect(result.message).to include(path)
+        expect { result }.to raise_error(StatusPage::Storage::Error)
       end
     end
 

ee/spec/support/shared_examples/status_page/publish_shared_examples.rb

@@ -47,10 +47,8 @@ RSpec.shared_examples 'publish incidents' do
         .and_raise(exception)
     end
 
-    it 'returns an error with exception' do
-      expect(result).to be_error
-      expect(result.message).to eq(exception.message)
-      expect(result.payload).to eq(error: exception)
+    it 'propagates the exception' do
+      expect { result }.to raise_error(exception)
     end
   end