Commit e373b2e9 authored by Filipa Lacerda's avatar Filipa Lacerda Committed by Phil Hughes

Fixes performance bar looking for a key in a undefined prop

parent 44fbb7a8
...@@ -42,7 +42,7 @@ export default { ...@@ -42,7 +42,7 @@ export default {
keys: ['feature', 'request'], keys: ['feature', 'request'],
}, },
], ],
simpleMetrics: ['redis', 'sidekiq'], simpleMetrics: ['redis'],
data() { data() {
return { currentRequestId: '' }; return { currentRequestId: '' };
}, },
......
<script> <script>
export default { export default {
props: { props: {
currentRequest: { currentRequest: {
type: Object, type: Object,
required: true, required: true,
},
metric: {
type: String,
required: true,
},
}, },
metric: { computed: {
type: String, duration() {
required: true, return (
this.currentRequest.details[this.metric] &&
this.currentRequest.details[this.metric].duration
);
},
calls() {
return (
this.currentRequest.details[this.metric] && this.currentRequest.details[this.metric].calls
);
},
}, },
}, };
};
</script> </script>
<template> <template>
<div <div
...@@ -21,9 +34,9 @@ export default { ...@@ -21,9 +34,9 @@ export default {
v-if="currentRequest.details" v-if="currentRequest.details"
class="bold" class="bold"
> >
{{ currentRequest.details[metric].duration }} {{ duration }}
/ /
{{ currentRequest.details[metric].calls }} {{ calls }}
</span> </span>
{{ metric }} {{ metric }}
</div> </div>
......
---
title: Fixes performance bar looking for a key in a undefined prop
merge_request:
author:
type: fixed
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment